Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make descriptions of calls to property accessors more consistent #1299

Closed
thomaslevesque opened this issue Feb 3, 2018 · 1 comment
Closed

Comments

@thomaslevesque
Copy link
Member

thomaslevesque commented Feb 3, 2018

When we assert calls on property accessors, the descriptions are inconsistent between the asserted calls and the list of actual calls made to the fake.

Currently we have this for the asserted calls:

  • getter: IFoo.get_Bar()
  • setter: IFoo.set_Bar(value: 42) (*)

But in the list of actual calls, we have this:

  • getter: IFoo.Bar
  • setter: IFoo.Bar = 42

Which I think is better. Anyway, we should probably make the descriptions consistent with each other.

(*) That's a lie. In fact we have Castle.Proxies.ObjectProxy_12 instead of IFoo, but it's another issue (#1298)

@blairconrad
Copy link
Member

This change has been released as part of FakeItEasy 4.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants