Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid asking proxy generators to create Fakes that they can't #1355

Closed
blairconrad opened this issue May 12, 2018 · 1 comment
Closed

Avoid asking proxy generators to create Fakes that they can't #1355

blairconrad opened this issue May 12, 2018 · 1 comment
Assignees
Milestone

Comments

@blairconrad
Copy link
Member

Currently we try to invoke the proxy generators, often once per available constructor, when making a Fake, even if the proxy generator can't possibly succeed.

For example, we try to use CastleDynamicProxyGenerator to create a string, even though strings are sealed (the CastleDynamicProxyGenerator exits early, but not before we create constructor arguments).

(From #1347.)

@blairconrad
Copy link
Member Author

This change has been released as part of FakeItEasy 4.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant