Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests under .NET Core 2.1 #1361

Closed
blairconrad opened this issue May 16, 2018 · 6 comments
Closed

Run tests under .NET Core 2.1 #1361

blairconrad opened this issue May 16, 2018 · 6 comments
Assignees
Labels
Milestone

Comments

@blairconrad
Copy link
Member

We currently run tests under .NET Framework 4.6.1 and .NET Core 1.0.
Sometimes newer platforms introduce changes in behaviour, as noted in #1345. Even though that one bug was resolved, we should test under the newer .NET Core to ensure that everything else works (and continues to work).

@silkfire
Copy link

Version 4.8.0 doesn't seem to be compatible with .NET Core 2.1, but 4.7.1 is. What figures?

@blairconrad
Copy link
Member Author

Hi, @silkfire. I'm unaware of the deficit. In what way do you find 4.8.0 not to be compatible with .NET Core 2.1?

@silkfire
Copy link

silkfire commented Aug 16, 2018

@blairconrad NuGet Package Manager says that it failed to install version 4.8.0 due to incompatible framework (netcoreapp2.1) when trying to upgrade.

image

@thomaslevesque
Copy link
Member

thomaslevesque commented Aug 16, 2018

Hi @silkfire,

Seems to work fine for me:

> dotnet new console -f netcoreapp2.1
> dotnet add package FakeItEasy -v 4.8.0

No error, the package is added and the project builds fine.

Looks like a NuGet bug...

@silkfire
Copy link

Yeah I had to clear my NuGet cache and after that it actually worked. NuGet bug indeed!

@blairconrad blairconrad self-assigned this Sep 5, 2018
@blairconrad blairconrad added this to the vNext milestone Sep 5, 2018
@blairconrad
Copy link
Member Author

This change has been released as part of FakeItEasy 4.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants