Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dummy failure exception should include reasons for failure #1397

Closed
blairconrad opened this issue Jul 25, 2018 · 1 comment
Closed

Dummy failure exception should include reasons for failure #1397

blairconrad opened this issue Jul 25, 2018 · 1 comment
Assignees
@blairconrad
Labels
🚀 enhancement
Milestone
4.8.0

Comments

@blairconrad
Copy link
Member

From #1367 (comment).

Because a Dummy can be made in one of about 6 different ways, I think we should indicate each of the things that went wrong along the chain. Just reporting which public constructors failed when we tried to instantiate a type would be misleading when the class (in theory) could've been made into a Dummy had it been fakeable or if it had a Dummy Factory.
@blairconrad blairconrad self-assigned this Jul 25, 2018
@blairconrad blairconrad mentioned this issue Jul 25, 2018
Merged
@blairconrad blairconrad added this to the vNext milestone Jul 27, 2018
@blairconrad
Copy link
Member Author

This change has been released as part of FakeItEasy 4.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blairconrad blairconrad

Labels
🚀 enhancement
Projects
None yet
Milestone
4.8.0
Development

No branches or pull requests
1 participant
@blairconrad