Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop fake serialization support in 5.0.0 #1500

Closed
blairconrad opened this issue Nov 20, 2018 · 2 comments
Closed

Drop fake serialization support in 5.0.0 #1500

blairconrad opened this issue Nov 20, 2018 · 2 comments
Assignees
@blairconrad
Labels
💔 breaking ✂️ removal
Milestone
5.0.0

Comments

@blairconrad
Copy link
Member

#1499 revealed that we cannot serialize fakes once they've been configured.
Also, if any call has been made to them and we serialize and deserialize the fake, the previously-made calls are lost. (Also note that some calls, such as a property set or get, implicitly configure the fake, so even that last statement is optimistic.)

I don't think there's any value in making the fakes binary serializable and can't imagine that anyone's using the ability in any meaningful way.
@thomaslevesque
Copy link
Member

👍

@thomaslevesque thomaslevesque added this to the vNext milestone Nov 30, 2018
@blairconrad blairconrad self-assigned this Dec 2, 2018
@blairconrad blairconrad mentioned this issue Dec 5, 2018
Merged
@thomaslevesque
Copy link
Member

This change has been released in FakeItEasy 5.0.0.

@blairconrad blairconrad mentioned this issue Jan 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blairconrad blairconrad

Labels
💔 breaking ✂️ removal
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@thomaslevesque @blairconrad