Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from licenseUrl to license in NuGet package metadata #1556

Closed
thomaslevesque opened this issue Jan 7, 2019 · 3 comments
Closed

Switch from licenseUrl to license in NuGet package metadata #1556

thomaslevesque opened this issue Jan 7, 2019 · 3 comments
Labels
🏗️ build
Milestone
5.0.1

Comments

@thomaslevesque
Copy link
Member

Because licenseUrl is being deprecated. See https://docs.microsoft.com/en-us/nuget/consume-packages/finding-and-choosing-packages#license-url-deprecation
@thomaslevesque
Copy link
Member Author

We basically have two options here:

  1. embed the license file in the package, and specify the relative path to the file
  2. specify a SPDX license identifier

I'd go with option 2, as it's simpler. Not sure how to specify this from the csproj, though...

@thomaslevesque
Copy link
Member Author

Not sure how to specify this from the csproj, though...

Like this, apparently: https://github.com/NuGet/Home/wiki/Packaging-License-within-the-nupkg-(Technical-Spec)#license-expression-pack

@thomaslevesque thomaslevesque mentioned this issue Jan 7, 2019
Merged
@blairconrad blairconrad added this to the vNext milestone Jan 7, 2019
@blairconrad
Copy link
Member

This change has been released as part of FakeItEasy 5.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏗️ build
Projects
None yet
Milestone
5.0.1
Development

No branches or pull requests
2 participants
@thomaslevesque @blairconrad