Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace readthedocs GitHub service integration with webhook #1565

Closed
blairconrad opened this issue Jan 17, 2019 · 12 comments
Closed

Replace readthedocs GitHub service integration with webhook #1565

blairconrad opened this issue Jan 17, 2019 · 12 comments
Assignees
Milestone

Comments

@blairconrad
Copy link
Member

blairconrad commented Jan 17, 2019

I got this in the e-mails and thought I should share.

Hello!
--
Your project, FakeItEasy, is currently using GitHub Services to trigger builds on Read the Docs. Effective January 31, 2019, GitHub will no longer process requests using the Services feature, and so Read the Docs will not receive notifications on updates to your repository.To continue building your Read the Docs project on changes to your repository, you will need to add a new webhook on your GitHub repository. You can either connect your GitHub account and configure a GitHub webhook integration, or you can add a generic webhook integration.You can find more information on our webhook intergrations in our documentation, at:https://docs.readthedocs.io/en/latest/webhooks.html#webhook-github-services

Hmm. I should probably also see if the e-mail could go to the fakeiteasy account. Oh. Unless you got the e-mail too, @thomaslevesque?

@blairconrad blairconrad self-assigned this Jan 18, 2019
@blairconrad blairconrad added this to the vNext milestone Jan 18, 2019
@blairconrad
Copy link
Member Author

Added https://github.com/FakeItEasy/FakeItEasy/settings/hooks/79351154. We may not know if it works until we release or change the docs.

@blairconrad
Copy link
Member Author

@thomaslevesque, I'm leaving open for a bit in case you want to check my settings. Otherwise, we can close and just keep an eye out for errors.

@thomaslevesque
Copy link
Member

Unless you got the e-mail too, @thomaslevesque?

I did

I'm leaving open for a bit in case you want to check my settings

Sounds good to me. Thanks for taking care of this!

@thomaslevesque
Copy link
Member

I'm leaving open for a bit in case you want to check my settings

Sounds good to me.

Sorry, I misread. I thought you wanted to keep open until we confirmed that it worked. The settings look good to me.

We could create a dummy branch to check that it builds correctly.

@blairconrad
Copy link
Member Author

@thomaslevesque
Copy link
Member

Apparently it triggered a build, but I don't know if specifically checked out this branch. Apparently the build checks out a commit, not a branch.

@blairconrad
Copy link
Member Author

Yeah. I saw that and wasn't sure what it built. The webhook was delivered successfully. I'm going to put a commit in there…

@blairconrad
Copy link
Member Author

Okay. After enabling that branch in read the docs, and disabling the GitHub service, then pushing a commit, I saw a successful build: https://fakeiteasy.readthedocs.io/en/test-read-the-docs/

I'm content if you are!

@blairconrad
Copy link
Member Author

Apparently it triggered a build, but I don't know if specifically checked out this branch. Apparently the build checks out a commit, not a branch.

It looked like it checked out a branch to me, if the logs are to be believed:

https://readthedocs.org/projects/fakeiteasy/builds/8411976/

git remote set-url origin https://github.com/FakeItEasy/FakeItEasy
git fetch --tags --prune --prune-tags --depth 50
git checkout --force origin/test-read-the-docs
git clean -d -f -f
python2.7 -mvirtualenv --no-site-packages --no-download /home/docs/checkouts/readthedocs.org/user_builds/fakeiteasy/envs/test-read-the-docs
/home/docs/checkouts/readthedocs.org/user_builds/fakeiteasy/envs/test-read-the-docs/bin/python -m pip install --upgrade --cache-dir /home/docs/checkouts/readthedocs.org/user_builds/fakeiteasy/.cache/pip pip
/home/docs/checkouts/readthedocs.org/user_builds/fakeiteasy/envs/test-read-the-docs/bin/python -m pip install --upgrade --cache-dir /home/docs/checkouts/readthedocs.org/user_builds/fakeiteasy/.cache/pip Pygments==2.2.0 setuptools<40 docutils==0.13.1 mock==1.0.1 pillow==2.6.1 alabaster>=0.7,<0.8,!=0.7.5 commonmark==0.5.4 recommonmark==0.4.0 mkdocs==0.17.3
cat mkdocs.yml
python /home/docs/checkouts/readthedocs.org/user_builds/fakeiteasy/envs/test-read-the-docs/bin/mkdocs build --clean

@thomaslevesque
Copy link
Member

I'm content if you are!

I am!

It looked like it checked out a branch to me, if the logs are to be believed

Not in this one: https://readthedocs.org/projects/fakeiteasy/builds/8411899/

@blairconrad
Copy link
Member Author

Oh. Um. That's odd. Maybe because it was started by the GitHub Service and not the webhook? (I am obviously making things up here.)

Regardless, I'll remove the branch and the Service integration, leaving us with only the webhook.

@blairconrad blairconrad changed the title Add readthedocs webhook Replace readthedocs GitHub service integration with webhook Jan 18, 2019
@blairconrad
Copy link
Member Author

This change has been released as part of FakeItEasy 5.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants