-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace readthedocs GitHub service integration with webhook #1565
Comments
Added https://github.com/FakeItEasy/FakeItEasy/settings/hooks/79351154. We may not know if it works until we release or change the docs. |
@thomaslevesque, I'm leaving open for a bit in case you want to check my settings. Otherwise, we can close and just keep an eye out for errors. |
I did
Sounds good to me. Thanks for taking care of this! |
Sorry, I misread. I thought you wanted to keep open until we confirmed that it worked. The settings look good to me. We could create a dummy branch to check that it builds correctly. |
Good idea! Pushed https://github.com/FakeItEasy/FakeItEasy/tree/test-read-the-docs |
Apparently it triggered a build, but I don't know if specifically checked out this branch. Apparently the build checks out a commit, not a branch. |
Yeah. I saw that and wasn't sure what it built. The webhook was delivered successfully. I'm going to put a commit in there… |
Okay. After enabling that branch in read the docs, and disabling the GitHub service, then pushing a commit, I saw a successful build: https://fakeiteasy.readthedocs.io/en/test-read-the-docs/ I'm content if you are! |
It looked like it checked out a branch to me, if the logs are to be believed: https://readthedocs.org/projects/fakeiteasy/builds/8411976/
|
I am!
Not in this one: https://readthedocs.org/projects/fakeiteasy/builds/8411899/ |
Oh. Um. That's odd. Maybe because it was started by the GitHub Service and not the webhook? (I am obviously making things up here.) Regardless, I'll remove the branch and the Service integration, leaving us with only the webhook. |
This change has been released as part of FakeItEasy 5.1.0. |
I got this in the e-mails and thought I should share.
Hmm. I should probably also see if the e-mail could go to the fakeiteasy account. Oh. Unless you got the e-mail too, @thomaslevesque?
The text was updated successfully, but these errors were encountered: