Embed FakeItEasy icon in package

[thomaslevesque]

PackageIconUrl is deprecated in .NET Core 3 SDK, and is replaced with PackageIcon, which refers to an embedded image.
https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets#packageiconurl

We should embed the icon in the package when we switch to .NET Core 3 SDK.

Note: I'm not seeing the NU5048 warning on FIE when using the latest SDK (3.0 RC1), not sure why. I tried on another project and the warning does appear.

[thomaslevesque]

Note: I'm not seeing the NU5048 warning on FIE when using the latest SDK (3.0 RC1), not sure why. I tried on another project and the warning does appear.

Ah, that was because of this:

FakeItEasy/src/Directory.Build.props

Line 12 in 1177af6

<NoPackageAnalysis>true</NoPackageAnalysis>

If we re-enable package analysis, there are some warnings that we should probably fix:

In FakeItEasy.Analyzer.CSharp:

warning NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below:
warning NU5128: - Add lib or ref assemblies for the netstandard1.1 target framework

In FakeItEasy.Analyzer.VisualBasic:

warning NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below:
warning NU5128: - Add lib or ref assemblies for the netstandard1.1 target framework

[blairconrad]

I'm for re-enabling the analysis if it's tractable.

[blairconrad]

This change has been released as part of FakeItEasy 5.3.0.