Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer 'not null' pattern to 'is object' tests #1796

Closed
thomaslevesque opened this issue Nov 11, 2020 · 4 comments · Fixed by #1805
Closed

Prefer 'not null' pattern to 'is object' tests #1796

thomaslevesque opened this issue Nov 11, 2020 · 4 comments · Fixed by #1805
Labels
🎁 contribution ☢️ tech-debt 🥇 first-time first-time contribution
Milestone
7.0.0

Comments

@thomaslevesque
Copy link
Member

At some point, we adopted the pattern x is object for all null checks. But now C# 9 introduced a much more explicit syntax: x is not null. We should consider adopting this syntax instead.

@blairconrad any objection?
@blairconrad
Copy link
Member

Make it so!

@Potapy4 Potapy4 mentioned this issue Nov 24, 2020
Merged
@blairconrad blairconrad changed the title Consider using 'not null' pattern Prefer 'not null' pattern to 'is object' tests Nov 24, 2020
@blairconrad blairconrad added the 🥇 first-time first-time contribution label Nov 25, 2020
@blairconrad blairconrad added this to the vNext milestone Dec 13, 2020
@afakebot
Copy link

This change has been released as part of FakeItEasy 7.0.0-beta.1.

@blairconrad
Copy link
Member

Thanks, @Potapy4. Look for your name in the release notes! 🥇

@blairconrad
Copy link
Member

This change has also been released as part of FakeItEasy 7.0.0.

Thanks again, @Potapy4.

This was referenced Mar 16, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 16, 2021
Merged
Closed
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎁 contribution ☢️ tech-debt 🥇 first-time first-time contribution
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Move to 'not null' pattern
3 participants
@thomaslevesque @blairconrad @afakebot