Provide placeholder names for anonymous parameters in received call descriptions #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaslevesque
approved these changes
Apr 15, 2023
thomaslevesque
approved these changes
Apr 16, 2023
There was a problem hiding this comment.
Thanks @blairconrad. Looks good to me, except the compilation errors...
😆 I'm lazy and just building for 6.0 at home. It's worked well enough for so long! |
Yeah, I do the same... |
thomaslevesque
approved these changes
Apr 16, 2023
…escriptions Follows from cfb82fe Provide placeholder names for anonymous parameters If a method has anonymous parameters, the description of a received call should use placeholder names just as we would for a call that is expected but not received.
|
Thanks for the quality reviews, @thomaslevesque! |
|
This change has been released as part of FakeItEasy 7.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows from fix for #1920.
If a method has anonymous parameters, the description of a received call should use placeholder names just as we would for a call that is expected but not received.