Documentation for ReturnsNextFromSequence is incorrect

[Dashue]

"Null will be returned when all the values in the sequence has been returned."
It actually seems to return default, 0 for a sequence of integers

[Dashue]

I'll fix this once my Task overloads of Returns, ReturnsLazily and ReturnsNextFromSequence is done

[blairconrad]

Setting to P3 and Ready and taken by @Dashue. Thanks, @Dashue!

[adamralph]

+1 some poor grammar in there too! 😉

[blairconrad]

I'm looking forward to this fix, but be aware that the actual behaviour is a little more complicated than "return default<T>. It's "revert to doing whatever you would've been doing had we not called ReturnsNextFromSequence". @Dashue, I expect that you tested by taking an otherwise-unconfigured method, so after the sequence was finished, the behaviour reverted to default unconfigured behaviour, which is (often) return default.

Perhaps the best fix is to just not make promises about what happens after the sequence is exhausted. As far as I know, we don't make promises about what happens once we're done with a Once or Twice call…

[adamralph]

Removing 1.19 milestone since we have other stuff ready to go live.

[adamralph]

assigned 1.19 milestone

[blairconrad]

@Dashue, thanks very much for raising this issue. Look out for your name in the release notes 🏆

https://www.nuget.org/packages/FakeItEasy/1.19.0
https://github.com/FakeItEasy/FakeItEasy/releases/tag/1.19.0