Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename IDummyDefinition, DummyDefinition #441

Closed
blairconrad opened this issue Jan 23, 2015 · 4 comments · Fixed by #451
Closed

Rename IDummyDefinition, DummyDefinition #441

blairconrad opened this issue Jan 23, 2015 · 4 comments · Fixed by #451
Assignees
@adamralph
Labels
💔 breaking P2 🚀 enhancement up-for-grabs
Milestone
2.0.0

Comments

@blairconrad
Copy link
Member

As suggested by @patrik-hagne in #402 (comment) and subsequently refined by @adamralph, IDummyDefinition could have a better name.

Current best suggestion (as I see it): IDummyFactory.

Make the change and the corresponding one for DummyDefinition<T>.
@blairconrad blairconrad added this to the 2.0.0 milestone Jan 23, 2015
@adamralph adamralph self-assigned this Feb 3, 2015
@adamralph adamralph mentioned this issue Feb 3, 2015
Merged
@blairconrad
Copy link
Member Author

In addition to renaming the types,

  • CanCreateDummyOfType (CreateDummy before 2.0.0) became CanCreate and
  • CreateDummyOfType became Create

@adamralph
Copy link
Contributor

Was it CanCreateDummy before 2.0?

@blairconrad
Copy link
Member Author

No. I completely messed that comment up. Thanks for noticing! Let's try again.

In addition to renaming the types,

  • CreateDummyOfType (CreateDummy before 2.0.0) became Create and
  • CanCreateDummyOfType (closest pre-2.0.0 analogue: ForType) became CanCreate

@blairconrad
Copy link
Member Author

This issue has been fixed in release 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamralph adamralph

Labels
💔 breaking P2 🚀 enhancement up-for-grabs
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

441 rename dummy definition
2 participants
@adamralph @blairconrad