Fix uninitialized Base::unique

FakerPHP · Apr 11, 2021 · a81eb04 · a81eb04
1 parent 91a6806
commit a81eb04
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -760,11 +760,6 @@ parameters:
 			count: 1
 			path: src/Faker/Provider/Base.php
 
-		-
-			message: "#^Negated boolean expression is always false\\.$#"
-			count: 1
-			path: src/Faker/Provider/Base.php
-
 		-
 			message: "#^Parameter \\$validator of method Faker\\\\Provider\\\\Base\\:\\:valid\\(\\) has invalid typehint type Faker\\\\Provider\\\\Closure\\.$#"
 			count: 1

diff --git a/src/Faker/Provider/Base.php b/src/Faker/Provider/Base.php
@@ -15,9 +15,9 @@ class Base
     protected $generator;
 
     /**
-     * @var \Faker\UniqueGenerator
+     * @var \Faker\UniqueGenerator|null
      */
-    protected $unique;
+    protected $unique = null;
 
     public function __construct(Generator $generator)
     {
@@ -621,7 +621,7 @@ public function optional($weight = 0.5, $default = null)
      */
     public function unique($reset = false, $maxRetries = 10000)
     {
-        if ($reset || !$this->unique) {
+        if ($reset || $this->unique === null) {
             $this->unique = new UniqueGenerator($this->generator, $maxRetries);
         }