Fix regexify escape backslash in character class (#434)

* TASK: fix regexify backslash in character class
FakerPHP · Jan 28, 2022 · dc988fe · dc988fe
1 parent 65ede06
commit dc988fe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Faker/Provider/Base.php b/src/Faker/Provider/Base.php
@@ -525,7 +525,9 @@ public static function regexify($regex = '')
         }, $regex);
         // All [ABC] become B (or A or C)
         $regex = preg_replace_callback('/\[([^\]]+)\]/', static function ($matches) {
-            $randomElement = Base::randomElement(str_split($matches[1]));
+            // remove backslashes (that are not followed by another backslash) because they are escape characters
+            $match = preg_replace('/\\\(?!\\\)/', '', $matches[1]);
+            $randomElement = Base::randomElement(str_split($match));
             //[.] should not be a random character, but a literal .
             return str_replace('.', '\.', $randomElement);
         }, $regex);

diff --git a/test/Faker/Provider/BaseTest.php b/test/Faker/Provider/BaseTest.php
@@ -333,6 +333,7 @@ public function regexifyDataProvider()
             ['[aeiou]', 'basic character class'],
             ['[a-z]', 'character class range'],
             ['[a-z1-9]', 'multiple character class range'],
+            ['[a-z\-]{4}', 'character class range with quantifier and escaped character'],
             ['a*b+c?', 'single character quantifiers'],
             ['a{2}', 'brackets quantifiers'],
             ['a{2,3}', 'min-max brackets quantifiers'],