Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nl_NL locale should use direct method instead of magic method #347

Merged
merged 1 commit into from
Jul 22, 2021
Merged

nl_NL locale should use direct method instead of magic method #347

merged 1 commit into from
Jul 22, 2021

Conversation

pimjansen
Copy link

@pimjansen pimjansen commented Jul 8, 2021 •
edited
Loading

What is the reason for this PR?

Locale is accessing magic methods which cause notices

Author's checklist

Summary of changes

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@pimjansen pimjansen added the bug Something isn't working label Jul 8, 2021
@pimjansen
Copy link
Author

Codecov is nothing i can improve here :)

@bram-pkg bram-pkg changed the title -nl_NL locale should use direct method instead of magic method nl_NL locale should use direct method instead of magic method Jul 22, 2021
@bram-pkg bram-pkg merged commit f3cab70 into FakerPHP:main Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bram-pkg bram-pkg bram-pkg approved these changes

@localheinz localheinz Awaiting requested review from localheinz

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Company nl_NL locale using a deprecated property accessor
2 participants
@pimjansen @bram-pkg