Enhancement: Enable void_return fixer

.php-cs-fixer.dist.php

@@ -200,5 +200,6 @@
                 'property',
             ],
         ],
+        'void_return' => true,
         'whitespace_after_comma_in_array' => true,
     ]);

src/Faker/Calculator/Isbn.php

@@ -34,7 +34,7 @@ public static function checksum(string $input): string
         $digits = str_split($input);
         array_walk(
             $digits,
-            static function (&$digit, $position) {
+            static function (&$digit, $position): void {
                 $digit = (10 - $position) * $digit;
             }
         );

src/Faker/Generator.php

@@ -597,7 +597,7 @@ public function ext(string $id): Extension\Extension
         return $extension;
     }
 
-    public function addProvider($provider)
+    public function addProvider($provider): void
     {
         array_unshift($this->providers, $provider);
 
@@ -682,7 +682,7 @@ public function valid(?\Closure $validator = null, int $maxRetries = 10000)
         return new ValidGenerator($this, $validator, $maxRetries);
     }
 
-    public function seed($seed = null)
+    public function seed($seed = null): void
     {
         if ($seed === null) {
             mt_srand();
@@ -966,7 +966,7 @@ public function __destruct()
         $this->seed();
     }
 
-    public function __wakeup()
+    public function __wakeup(): void
     {
         $this->formatters = [];
     }

src/Faker/ORM/CakePHP/EntityPopulator.php

@@ -27,17 +27,17 @@ public function __get($name)
     /**
      * @param string $name
      */
-    public function __set($name, $value)
+    public function __set($name, $value): void
     {
         $this->{$name} = $value;
     }
 
-    public function mergeColumnFormattersWith($columnFormatters)
+    public function mergeColumnFormattersWith($columnFormatters): void
     {
         $this->columnFormatters = array_merge($this->columnFormatters, $columnFormatters);
     }
 
-    public function mergeModifiersWith($modifiers)
+    public function mergeModifiersWith($modifiers): void
     {
         $this->modifiers = array_merge($this->modifiers, $modifiers);
     }
@@ -155,7 +155,7 @@ public function execute($class, $insertedEntities, $options = [])
         return $entity->{$pk[0]};
     }
 
-    public function setConnection($name)
+    public function setConnection($name): void
     {
         $this->connectionName = $name;
     }

src/Faker/ORM/Doctrine/EntityPopulator.php

@@ -38,7 +38,7 @@ public function getClass()
         return $this->class->getName();
     }
 
-    public function setColumnFormatters($columnFormatters)
+    public function setColumnFormatters($columnFormatters): void
     {
         $this->columnFormatters = $columnFormatters;
     }
@@ -51,12 +51,12 @@ public function getColumnFormatters()
         return $this->columnFormatters;
     }
 
-    public function mergeColumnFormattersWith($columnFormatters)
+    public function mergeColumnFormattersWith($columnFormatters): void
     {
         $this->columnFormatters = array_merge($this->columnFormatters, $columnFormatters);
     }
 
-    public function setModifiers(array $modifiers)
+    public function setModifiers(array $modifiers): void
     {
         $this->modifiers = $modifiers;
     }
@@ -69,7 +69,7 @@ public function getModifiers()
         return $this->modifiers;
     }
 
-    public function mergeModifiersWith(array $modifiers)
+    public function mergeModifiersWith(array $modifiers): void
     {
         $this->modifiers = array_merge($this->modifiers, $modifiers);
     }
@@ -193,7 +193,7 @@ public function execute(ObjectManager $manager, $insertedEntities, $generateId =
         return $obj;
     }
 
-    private function fillColumns($obj, $insertedEntities)
+    private function fillColumns($obj, $insertedEntities): void
     {
         foreach ($this->columnFormatters as $field => $format) {
             if (null !== $format) {
@@ -220,7 +220,7 @@ private function fillColumns($obj, $insertedEntities)
         }
     }
 
-    private function callMethods($obj, $insertedEntities)
+    private function callMethods($obj, $insertedEntities): void
     {
         foreach ($this->getModifiers() as $modifier) {
             $modifier($obj, $insertedEntities);

src/Faker/ORM/Doctrine/Populator.php

@@ -61,7 +61,7 @@ public function __construct(Generator $generator, ObjectManager $manager = null,
      * @param mixed $entity A Doctrine classname, or a \Faker\ORM\Doctrine\EntityPopulator instance
      * @param int   $number The number of entities to populate
      */
-    public function addEntity($entity, $number, $customColumnFormatters = [], $customModifiers = [], $generateId = false)
+    public function addEntity($entity, $number, $customColumnFormatters = [], $customModifiers = [], $generateId = false): void
     {
         if (!$entity instanceof \Faker\ORM\Doctrine\EntityPopulator) {
             if (null === $this->manager) {

src/Faker/ORM/Mandango/EntityPopulator.php

@@ -29,7 +29,7 @@ public function getClass()
         return $this->class;
     }
 
-    public function setColumnFormatters($columnFormatters)
+    public function setColumnFormatters($columnFormatters): void
     {
         $this->columnFormatters = $columnFormatters;
     }
@@ -42,7 +42,7 @@ public function getColumnFormatters()
         return $this->columnFormatters;
     }
 
-    public function mergeColumnFormattersWith($columnFormatters)
+    public function mergeColumnFormattersWith($columnFormatters): void
     {
         $this->columnFormatters = array_merge($this->columnFormatters, $columnFormatters);
     }

src/Faker/ORM/Mandango/Populator.php

@@ -27,7 +27,7 @@ public function __construct(\Faker\Generator $generator, Mandango $mandango)
      * @param mixed $entity A Propel ActiveRecord classname, or a \Faker\ORM\Propel\EntityPopulator instance
      * @param int   $number The number of entities to populate
      */
-    public function addEntity($entity, $number, $customColumnFormatters = [])
+    public function addEntity($entity, $number, $customColumnFormatters = []): void
     {
         if (!$entity instanceof \Faker\ORM\Mandango\EntityPopulator) {
             $entity = new \Faker\ORM\Mandango\EntityPopulator($entity);

src/Faker/ORM/Propel/EntityPopulator.php

@@ -29,7 +29,7 @@ public function getClass()
         return $this->class;
     }
 
-    public function setColumnFormatters($columnFormatters)
+    public function setColumnFormatters($columnFormatters): void
     {
         $this->columnFormatters = $columnFormatters;
     }
@@ -42,7 +42,7 @@ public function getColumnFormatters()
         return $this->columnFormatters;
     }
 
-    public function mergeColumnFormattersWith($columnFormatters)
+    public function mergeColumnFormattersWith($columnFormatters): void
     {
         $this->columnFormatters = array_merge($this->columnFormatters, $columnFormatters);
     }
@@ -126,7 +126,7 @@ protected function isColumnBehavior(\ColumnMap $columnMap)
         return false;
     }
 
-    public function setModifiers($modifiers)
+    public function setModifiers($modifiers): void
     {
         $this->modifiers = $modifiers;
     }
@@ -139,7 +139,7 @@ public function getModifiers()
         return $this->modifiers;
     }
 
-    public function mergeModifiersWith($modifiers)
+    public function mergeModifiersWith($modifiers): void
     {
         $this->modifiers = array_merge($this->modifiers, $modifiers);
     }
@@ -157,7 +157,7 @@ public function guessModifiers(\Faker\Generator $generator)
         foreach ($tableMap->getBehaviors() as $name => $params) {
             switch ($name) {
                 case 'nested_set':
-                    $modifiers['nested_set'] = static function ($obj, $inserted) use ($class, $generator) {
+                    $modifiers['nested_set'] = static function ($obj, $inserted) use ($class, $generator): void {
                         if (isset($inserted[$class])) {
                             $queryClass = $class . 'Query';
                             $parent = $queryClass::create()->findPk($generator->randomElement($inserted[$class]));
@@ -170,7 +170,7 @@ public function guessModifiers(\Faker\Generator $generator)
                     break;
 
                 case 'sortable':
-                    $modifiers['sortable'] = static function ($obj, $inserted) use ($class, $generator) {
+                    $modifiers['sortable'] = static function ($obj, $inserted) use ($class, $generator): void {
                         $obj->insertAtRank($generator->numberBetween(1, count($inserted[$class] ?? []) + 1));
                     };
 

src/Faker/ORM/Propel/Populator.php

@@ -23,7 +23,7 @@ public function __construct(\Faker\Generator $generator)
      * @param mixed $entity A Propel ActiveRecord classname, or a \Faker\ORM\Propel\EntityPopulator instance
      * @param int   $number The number of entities to populate
      */
-    public function addEntity($entity, $number, $customColumnFormatters = [], $customModifiers = [])
+    public function addEntity($entity, $number, $customColumnFormatters = [], $customModifiers = []): void
     {
         if (!$entity instanceof \Faker\ORM\Propel\EntityPopulator) {
             $entity = new \Faker\ORM\Propel\EntityPopulator($entity);

src/Faker/ORM/Propel2/EntityPopulator.php

@@ -30,7 +30,7 @@ public function getClass()
         return $this->class;
     }
 
-    public function setColumnFormatters($columnFormatters)
+    public function setColumnFormatters($columnFormatters): void
     {
         $this->columnFormatters = $columnFormatters;
     }
@@ -43,7 +43,7 @@ public function getColumnFormatters()
         return $this->columnFormatters;
     }
 
-    public function mergeColumnFormattersWith($columnFormatters)
+    public function mergeColumnFormattersWith($columnFormatters): void
     {
         $this->columnFormatters = array_merge($this->columnFormatters, $columnFormatters);
     }
@@ -129,7 +129,7 @@ protected function isColumnBehavior(ColumnMap $columnMap)
         return false;
     }
 
-    public function setModifiers($modifiers)
+    public function setModifiers($modifiers): void
     {
         $this->modifiers = $modifiers;
     }
@@ -142,7 +142,7 @@ public function getModifiers()
         return $this->modifiers;
     }
 
-    public function mergeModifiersWith($modifiers)
+    public function mergeModifiersWith($modifiers): void
     {
         $this->modifiers = array_merge($this->modifiers, $modifiers);
     }
@@ -160,7 +160,7 @@ public function guessModifiers(\Faker\Generator $generator)
         foreach ($tableMap->getBehaviors() as $name => $params) {
             switch ($name) {
                 case 'nested_set':
-                    $modifiers['nested_set'] = static function ($obj, $inserted) use ($class, $generator) {
+                    $modifiers['nested_set'] = static function ($obj, $inserted) use ($class, $generator): void {
                         if (isset($inserted[$class])) {
                             $queryClass = $class . 'Query';
                             $parent = $queryClass::create()->findPk($generator->randomElement($inserted[$class]));
@@ -173,7 +173,7 @@ public function guessModifiers(\Faker\Generator $generator)
                     break;
 
                 case 'sortable':
-                    $modifiers['sortable'] = static function ($obj, $inserted) use ($class, $generator) {
+                    $modifiers['sortable'] = static function ($obj, $inserted) use ($class, $generator): void {
                         $obj->insertAtRank($generator->numberBetween(1, count($inserted[$class] ?? []) + 1));
                     };
 

src/Faker/ORM/Propel2/Populator.php

@@ -26,7 +26,7 @@ public function __construct(\Faker\Generator $generator)
      * @param mixed $entity A Propel ActiveRecord classname, or a \Faker\ORM\Propel2\EntityPopulator instance
      * @param int   $number The number of entities to populate
      */
-    public function addEntity($entity, $number, $customColumnFormatters = [], $customModifiers = [])
+    public function addEntity($entity, $number, $customColumnFormatters = [], $customModifiers = []): void
     {
         if (!$entity instanceof \Faker\ORM\Propel2\EntityPopulator) {
             $entity = new \Faker\ORM\Propel2\EntityPopulator($entity);

src/Faker/ORM/Spot/EntityPopulator.php

@@ -60,7 +60,7 @@ public function getMapper()
         return $this->mapper;
     }
 
-    public function setColumnFormatters($columnFormatters)
+    public function setColumnFormatters($columnFormatters): void
     {
         $this->columnFormatters = $columnFormatters;
     }
@@ -73,12 +73,12 @@ public function getColumnFormatters()
         return $this->columnFormatters;
     }
 
-    public function mergeColumnFormattersWith($columnFormatters)
+    public function mergeColumnFormattersWith($columnFormatters): void
     {
         $this->columnFormatters = array_merge($this->columnFormatters, $columnFormatters);
     }
 
-    public function setModifiers(array $modifiers)
+    public function setModifiers(array $modifiers): void
     {
         $this->modifiers = $modifiers;
     }
@@ -91,7 +91,7 @@ public function getModifiers()
         return $this->modifiers;
     }
 
-    public function mergeModifiersWith(array $modifiers)
+    public function mergeModifiersWith(array $modifiers): void
     {
         $this->modifiers = array_merge($this->modifiers, $modifiers);
     }
@@ -180,7 +180,7 @@ public function execute($insertedEntities)
         return $obj;
     }
 
-    private function fillColumns($obj, $insertedEntities)
+    private function fillColumns($obj, $insertedEntities): void
     {
         foreach ($this->columnFormatters as $field => $format) {
             if (null !== $format) {
@@ -190,7 +190,7 @@ private function fillColumns($obj, $insertedEntities)
         }
     }
 
-    private function callMethods($obj, $insertedEntities)
+    private function callMethods($obj, $insertedEntities): void
     {
         foreach ($this->getModifiers() as $modifier) {
             $modifier($obj, $insertedEntities);

src/Faker/ORM/Spot/Populator.php

@@ -38,7 +38,7 @@ public function addEntity(
         $customColumnFormatters = [],
         $customModifiers = [],
         $useExistingData = false
-    ) {
+    ): void {
         $mapper = $this->locator->mapper($entityName);
 
         if (null === $mapper) {

src/Faker/Provider/DateTime.php

@@ -356,7 +356,7 @@ private static function setTimezone(\DateTime $dt, $timezone)
      *
      * @param string $timezone
      */
-    public static function setDefaultTimezone($timezone = null)
+    public static function setDefaultTimezone($timezone = null): void
     {
         static::$defaultTimezone = $timezone;
     }