Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(import): support engine path #280

Merged
merged 1 commit into from
Jun 28, 2024
Merged

feat(import): support engine path #280

merged 1 commit into from
Jun 28, 2024

Conversation

FalcoSuessgott
Copy link
Owner

@FalcoSuessgott FalcoSuessgott commented Jun 22, 2024

fixes #276 based on #277.

  • detect the engine path from the input if possible
  • support -e in vkv import
  • correctly append -p when using -e.
  • docs
  • test suite (see below)

test cases

  • secrets imported, exported from original path
  • secrets imported with overwritten path, exported from overwritten path
  • import secrets, overwrite path with engine path, export from engine path
  • import secrets, overwrite path with engine path and subpath, export from engine path
  • import secrets, overwrite path and subpath, read from path

@FalcoSuessgott FalcoSuessgott force-pushed the import_engine_2 branch 3 times, most recently from 70dd76f to 5d41658 Compare June 28, 2024 02:04
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 69.65517% with 44 lines in your changes missing coverage. Please review.

Project coverage is 71.55%. Comparing base (6b528bc) to head (f391783).
Report is 104 commits behind head on master.

Files Patch % Lines
cmd/import.go 70.51% 13 Missing and 10 partials ⚠️
pkg/vault/engine.go 60.00% 5 Missing and 5 partials ⚠️
pkg/printer/secret/secret_printer.go 37.50% 5 Missing ⚠️
pkg/printer/secret/base.go 25.00% 3 Missing ⚠️
cmd/export.go 77.77% 1 Missing and 1 partial ⚠️
pkg/utils/utils.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   69.59%   71.55%   +1.96%     
==========================================
  Files          29       35       +6     
  Lines        1322     1596     +274     
==========================================
+ Hits          920     1142     +222     
- Misses        290      315      +25     
- Partials      112      139      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FalcoSuessgott FalcoSuessgott merged commit bd3c05c into master Jun 28, 2024
7 checks passed
@FalcoSuessgott FalcoSuessgott deleted the import_engine_2 branch June 28, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot correctly import a json file with an engine path that contains a special character '/'.
1 participant