Skip to content

Commit

Permalink
address review
Browse files Browse the repository at this point in the history
  • Loading branch information
AviAvni committed Mar 3, 2024
1 parent abdd3a8 commit 446424b
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
4 changes: 1 addition & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,7 @@ $(REDISEARCH_LIBS):
$(SHOW)$(MAKE) -C $(REDISEARCH_DIR) STATIC=1 BINROOT=$(REDISEARCH_BINROOT) CC=$(CC) CXX=$(CXX)


ifeq ($(DEBUG),1)
CARGO_FLAGS=
else
ifneq ($(DEBUG),1)
CARGO_FLAGS=--release
endif

Expand Down
3 changes: 2 additions & 1 deletion src/graph/graphcontext.c
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ int GraphContext_DeleteIndex
}

// remove a single node from all indices that refer to it
void _DeleteNodeFromIndices
static void _DeleteNodeFromIndices
(
GraphContext *gc, // graph context
Node *n, // node to remove from index
Expand Down Expand Up @@ -720,6 +720,7 @@ void GraphContext_DeleteEdgeFromIndices
int relation_id = Edge_GetRelationID(e);

s = GraphContext_GetSchemaByID(gc, relation_id, SCHEMA_EDGE);
ASSERT(s != NULL);

// update any indices this entity is represented in
Schema_RemoveEdgeFromIndex(s, e);
Expand Down
2 changes: 1 addition & 1 deletion src/graph/graphcontext.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
// can use the graph version to understand if the schema was modified
// and take action accordingly

typedef struct GraphContext {
typedef struct {
Graph *g; // container for all matrices and entity properties
int ref_count; // number of active references
rax *attributes; // from strings to attribute IDs
Expand Down
2 changes: 1 addition & 1 deletion src/index/index_field.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

// type of index field
// multiple types can be combined via bitwise OR
typedef enum IndexFieldType {
typedef enum {
INDEX_FLD_UNKNOWN = 0x00, // unknown field type
INDEX_FLD_FULLTEXT = 0x01, // full text field
INDEX_FLD_NUMERIC = 0x02, // numeric field
Expand Down

0 comments on commit 446424b

Please sign in to comment.