Add vector index capabilities #3
Conversation
swilly22
force-pushed
the
vector-index
branch
from
74bf93a
to
921f168
Compare
…nto vector-index
| //-------------------------------------------------------------------------- | ||
|
|
||
| Index idx = NULL; | ||
| if(t == INDEX_FLD_RANGE) { |
There was a problem hiding this comment.
I don't believe I can as INDEX_FLD_RANGE isn't an enum value but a macro oring 3 different enum values.
switch case can't have INDEX_FLD_RANGE as one of its cases
| IDX_FULLTEXT = 2, | ||
| IDX_ANY = 0, | ||
| IDX_EXACT_MATCH = 1, | ||
| IDX_FULLTEXT = 2, |
There was a problem hiding this comment.
I believe it is, old encoded RDBs will contain index type.
| t == INDEX_FLD_RANGE || | ||
| t == INDEX_FLD_VECTOR); | ||
|
|
||
| if(t == INDEX_FLD_FULLTEXT) { |
There was a problem hiding this comment.
I don't believe I can as INDEX_FLD_RANGE isn't an enum value but a macro oring 3 different enum values.
switch case can't have INDEX_FLD_RANGE as one of its cases
| a->type |= b->type; | ||
|
|
||
| // merge options | ||
| if(b->type & INDEX_FLD_FULLTEXT) { |
There was a problem hiding this comment.
I don't believe I can as INDEX_FLD_RANGE isn't an enum value but a macro oring 3 different enum values.
switch case can't have INDEX_FLD_RANGE as one of its cases
| ErrorCtx_SetError(EMSG_MUST_BE, "Stopword", "string"); | ||
| return PROCEDURE_ERR; | ||
| } | ||
| if(!SIArray_AllOfType(sw, T_STRING)) { |
There was a problem hiding this comment.
isn't this function now same as in index_fulltext_create.c?
There was a problem hiding this comment.
Similar, this one knows how to handle all of the different configuration one can specify when creating a full-text index with multiple fields, where each field has its own configuration, this is not possible with the CREATE FULLTEXT INDEX syntax
| RedisModuleIO *rdb | ||
| ); | ||
|
|
||
| void RdbLoadNodes_v15 |
There was a problem hiding this comment.
why we need version 15 you added version 14 in this pr
No description provided.