fix error reporting in vector query

[swilly22]

Fixed error reporting when performing vector search

Summary by CodeRabbit

• Refactor
  • Simplified error handling for invalid arguments in vector query procedures.
  • Enhanced error messaging for specific invalid argument scenarios.

[coderabbitai]

Walkthrough

The recent modifications focus on refining error handling within vector query procedures. Invalid argument handling has been streamlined in one function, making the process more efficient by directly returning an error. Meanwhile, in two other functions, the error reporting mechanism has been enhanced, ensuring that specific error messages are provided when invalid arguments are detected. This blend of simplification and enhancement aims to improve both the developer's experience and the system's robustness.

Changes

File(s)	Change Summary
src/procedures/proc_vector_query.c	Simplified error handling in Proc_VectorQueryInvoke; enhanced error messages in Proc_VectorQueryNodeInvoke and Proc_VectorQueryRelInvoke for invalid arguments.

🐇✨
In the realm of code, where logic trees sway,
A rabbit hopped through, refining the fray.
With a flick and a hop, errors neatly align,
In a burrow of bytes, where the stars realign.
🌌🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 9f11502 and 603acd4.

Files selected for processing (1)

• src/procedures/proc_vector_query.c (3 hunks)

Additional comments: 2

src/procedures/proc_vector_query.c (2)

• 285-289: Setting a specific error message in Proc_VectorQueryNodeInvoke enhances error reporting. Ensure consistency in error messages across different parts of the application for a unified user experience.
• 326-330: Similar to Proc_VectorQueryNodeInvoke, the enhanced error reporting in Proc_VectorQueryRelInvoke is a positive change. Verify that the error message aligns with the application's overall error reporting strategy.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 603acd4 and 978031c.

Files selected for processing (1)

• src/procedures/proc_vector_query.c (3 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/procedures/proc_vector_query.c