resolve compilation warnings

[swilly22]

Removed const quarriers from attributes which are modified after the AST is constructed. e.g. Replace* functions.

Summary by CodeRabbit

• Refactor
  • Updated internal data structures to enhance flexibility in query and statement manipulation.

[coderabbitai]

Walkthrough

The overall change involves the removal of the const qualifier from pointers to cypher_astnode_t structures across several files in the libcypher-parser library. This adjustment allows for the modification of AST nodes once they have been created, reflecting a shift towards more flexible manipulation of the abstract syntax tree within the library.

Changes

Files	Change Summary
.../ast_foreach.c	Removed const from clauses array type in foreach_clause struct.
.../ast_query.c, .../cypher-parser.h.in	Removed const from clauses and body types, added casts where necessary.
.../ast_statement.c, .../cypher-parser.h.in	Altered body field and function parameters to non-constant pointers.

🎉🐰✨
Changes sweep through the code, so neat,
const qualifiers take their leave, discreet.
Now nodes can dance, and structures bend,
In AST's garden, where types amend.
Here's to the flexibility we greet!
🌟📝🌿

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 57d12ac and 95fcd02.

Files selected for processing (4)

• deps/libcypher-parser/lib/src/ast_foreach.c (1 hunks)
• deps/libcypher-parser/lib/src/ast_query.c (2 hunks)
• deps/libcypher-parser/lib/src/ast_statement.c (3 hunks)
• deps/libcypher-parser/lib/src/cypher-parser.h.in (2 hunks)

Files not reviewed due to errors (1)

• (no review received)

Additional comments: 6

deps/libcypher-parser/lib/src/ast_statement.c (3)

• 25-25: The removal of const from body in struct statement aligns with the PR objectives to address const-correctness issues. Ensure all related function implementations are updated accordingly.
• 44-44: The signature of cypher_ast_statement has been correctly updated to accept a non-const body parameter, reflecting the intended mutability of the AST node.
• 83-83: The cypher_ast_statement_replace_body function now correctly accepts a non-const body parameter, allowing for the intended modification of the AST node.

deps/libcypher-parser/lib/src/ast_foreach.c (1)

• 29-29: The modification of the clauses array type from const cypher_astnode_t * to cypher_astnode_t * in foreach_clause struct is consistent with the PR's goal to correct const-correctness issues.

deps/libcypher-parser/lib/src/ast_query.c (2)

• 29-29: The removal of const from the clauses member in the query struct correctly addresses const-correctness issues, aligning with the PR objectives.
• 222-222: The cast to const cypher_astnode_t * const * in the detailstr function is a necessary adjustment following the removal of const from the clauses member, ensuring compatibility with the snprint_sequence function.