-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove runtime tests, remove extra prints #575
Merged
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
213e152
remove runtime tests, remove extra prints
swilly22 f81c5ef
Merge branch 'master' into clean-flowtest
swilly22 3e63878
update tests requirements
swilly22 5820c29
remove pathos requierment, switch to python asyncio
swilly22 f6b0c89
switch to asyncio.run
swilly22 195213d
Merge branch 'master' into clean-flowtest
swilly22 b4c9f8a
install RLTest directly from github repo
swilly22 aef0369
Merge branch 'master' into clean-flowtest
swilly22 863f8fa
update dockerfile compiler
swilly22 addd26a
install redis
AviAvni 3f97a3d
remove sudu
AviAvni 105b3fd
remove sudo
AviAvni 9ac88a1
fix setup redis
AviAvni de25493
fix install redis
AviAvni 124c957
use venv
AviAvni 0f29161
set venv in path
AviAvni 1354c16
fix sanitizer
AviAvni 904e21b
fix sanitizer build
AviAvni e5bc8a9
fix sanitier build
AviAvni ea58192
fix sanitizer build
AviAvni 0a81779
fix sanitizer build
AviAvni 9652cb2
add clang to sanitizer
AviAvni 02cadd1
add libc6-dbg
AviAvni d25813a
.
AviAvni 3ec26a0
add libomp
AviAvni 828ddca
fix sanitizer
AviAvni 223ed89
fix redis install
AviAvni fffd8ac
fix redis
AviAvni 2d3bddc
reduce flow test parallelism
swilly22 49e5b6c
create connection pool inside async func and make sure to close it
swilly22 7620d13
close async connection
swilly22 90930e9
remove flushall
swilly22 0cad99f
Merge branch 'master' into clean-flowtest
swilly22 332c525
specify port for connection pool
swilly22 4cd040a
address PR comments
swilly22 b7ea7bf
Update build.yml
swilly22 2ce3c82
Update test_cache.py
swilly22 cb7348e
Update test_concurrent_query.py
swilly22 741d5c3
Update test_concurrent_query.py
swilly22 8a39826
Update test_edge_index_scans.py
swilly22 96d9d46
Update test_encode_decode.py
swilly22 ecf3aec
Update test_graph_deletion.py
swilly22 1b64d96
Update test_graph_deletion.py
swilly22 1ccd192
Update test_path_filter.py
swilly22 d1052a8
address PR comments
swilly22 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
ARG TARGETPLATFORM=linux/amd64 | ||
|
||
FROM --platform=$TARGETPLATFORM falkordb/falkordb-build:latest as builder | ||
FROM --platform=$TARGETPLATFORM falkordb/falkordb-build:ubuntu as builder | ||
|
||
WORKDIR /FalkorDB | ||
|
||
COPY . /FalkorDB | ||
|
||
RUN make | ||
RUN make |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
The removal of
max_run_time_ms
from theQueryInfo
constructor has been widely adopted across the project, aligning with the updated constructor signature. However, an exception was found in./tests/flow/test_graph_deletion.py:175
, wheremax_run_time_ms
is still being used. This indicates that while most instances have been updated, there remains at least one instance that does not match the new constructor signature.Analysis chain
The removal of
max_run_time_ms
from theQueryInfo
constructor simplifies query initialization by eliminating runtime checks. Ensure all instances ofQueryInfo
across the project are updated to match the new constructor signature.Scripts Executed
The following scripts were executed for the analysis:
Script:
Length of output: 66
Script:
Length of output: 50983
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swilly22 check this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.