Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

600 add browser usage for the docker image #601

Merged
merged 2 commits into from
Mar 29, 2024
Merged

600 add browser usage for the docker image #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0a4493
add instructions to run browser UI
Mar 28, 2024
67d7423
set hostname to 0.0.0.0
Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,16 @@ To quickly try out FalkorDB, launch an instance using docker:
docker run -p 6379:6379 -it --rm falkordb/falkordb:edge
```

Once loaded you can interact with FalkorDB using any of the supported [client libraries](#Client-libraries)
Or, to use the built-in browser-based interface, run:

```
docker run -p 6379:6379 -p 3000:3000 -it --rm falkordb/falkordb:edge
```

Then, open your browser and navigate to `http://localhost:3000`.


You can also interact with FalkorDB using any of the supported [client libraries](#Client-libraries)

Here we'll use [FalkorDB Python client](https://pypi.org/project/FalkorDB/) to create a small graph representing a subset of motorcycle riders and teams taking part in the MotoGP league, once created we'll start querying our data.

Expand Down
2 changes: 1 addition & 1 deletion build/docker/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ if [ ${BROWSER:-1} -eq 1 ]
then
if [ -d /FalkorDBBrowser ]
then
cd /FalkorDBBrowser && node server.js &
cd /FalkorDBBrowser && HOSTNAME="0.0.0.0" node server.js &
fi
fi

Comment on lines 4 to 10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]

Consider adding a shebang at the beginning of the script to specify the shell interpreter explicitly, such as #!/bin/bash. This ensures that the script runs under the expected shell environment, improving portability and predictability.

+ #!/bin/bash

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [3-3]

To prevent globbing and word splitting issues, it's recommended to double-quote variables when they are expanded. This is a best practice in shell scripting that enhances the script's robustness and security.

- if [ ${BROWSER:-1} -eq 1 ]
+ if [ "${BROWSER:-1}" -eq 1 ]

- if [ ${TLS:-0} -eq 1 ]
+ if [ "${TLS:-0}" -eq 1 ]

- redis-server --protected-mode no ${REDIS_ARGS:-""} \
+ redis-server --protected-mode no "${REDIS_ARGS:-""}" \

- redis-server --protected-mode no ${REDIS_ARGS} \
+ redis-server --protected-mode no "${REDIS_ARGS}" \

- --loadmodule ${MODULE_DIR}/falkordb.so ${FALKORDB_ARGS:-""}
+ --loadmodule "${MODULE_DIR}/falkordb.so" "${FALKORDB_ARGS:-""}"

- --loadmodule ${MODULE_DIR}/falkordb.so ${FALKORDB_ARGS:-""}
+ --loadmodule "${MODULE_DIR}/falkordb.so" "${FALKORDB_ARGS:-""}"

Also applies to: 11-11, 14-14, 20-20, 22-22, 23-23

Expand Down
Loading