Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TweakmProPlace doesnt work properly with Flexible Block Placement #26

Closed
ghost opened this issue Dec 31, 2022 · 17 comments
Closed

TweakmProPlace doesnt work properly with Flexible Block Placement #26

ghost opened this issue Dec 31, 2022 · 17 comments
Labels
compatibility Not compatible enough with other mod

Comments

@ghost
Copy link

ghost commented Dec 31, 2022

QOL to TWEAKMPROPLACE

TweakmProPlace's new rotation check doesn't properly support Flexible Block Placement whilst accurate block placement works fine alongside ProPlace.

To Reproduce

Steps to reproduce the behavior:

  1. Attempt to use Flexible Block Placement options, example: rotation, offset, and adjacent.

What you expect to see: being able to use Flexible alongside ProPlace without getting a debug/error for "not placing it towards a direction".

What actually happens: Error text/debug appears reminding the user that it is not possible to place the block with TweakmProPlace enabled whilst using Flexible Block Placement.

Environment

  • Minecraft version: '1.19.3, 1.19.2'
  • TweakerMore version: '3.8+'
@ghost ghost changed the title TweakmProPlace doesnt work properly. with Flexible Block Placement TweakmProPlace doesnt work properly with Flexible Block Placement Dec 31, 2022
Fallen-Breath added a commit that referenced this issue Jan 7, 2023
@Fallen-Breath
Pro Place features improved: injection point adjustment again
bf6e0a6 
inject to tweakeroo -> inject to minecraf, for complete tweakeroo feature compact
removed dependency requirement on tweakeroo
fixed #26
@Fallen-Breath
Copy link
Owner

try this build https://github.com/Fallen-Breath/tweakermore/actions/runs/3862525360

@ghost
Copy link
Author

ghost commented Jan 8, 2023 •
edited by Fallen-Breath

Didn't work for me for some reason. could it be my mods running?

Crash Log: https://pastebin.com/K73dSCKT

@Fallen-Breath
Copy link
Owner

Didn't work for me for some reason. could it be my mods running?

Yeah seems like there are mod conflictions with tweakermore v3.9. You can open a new issue for this

@ghost
Copy link
Author

ghost commented Jan 8, 2023

alrighty.

@ghost
Copy link
Author

ghost commented Jan 8, 2023

ive done some further testing disabling all mods (besides the obvious like malilib) and it appears to still continue crashing. I've looked at the crash log and it has to do with something text related / hover text related from what i've seen. Could this be from the hovertext reminder for whenever u turn on TweakmProPlace or when you do an action it cancels?

@Fallen-Breath
Copy link
Owner

The crash doesn't related to this issue or TweakmProPlace, as I said it's due to changes in tweakermore v3.9. I'll suggest to open a new issue for this

@Fallen-Breath
Copy link
Owner

Fallen-Breath commented Jan 8, 2023 •
edited

Just checked the crash report again, I think you were using tweakermore for mc1.19.2 in mc 1.19.3, and this will be the reason of the crash: mc version mismatch

@ghost
Copy link
Author

ghost commented Jan 8, 2023

Oh I see. I thought the 1.19.x file would include 1.19.1+ my bad haha.

@ghost ghost closed this as completed Jan 8, 2023
@ghost
Copy link
Author

ghost commented Jan 9, 2023

I've found an issue with the build u have made.
1: when using flexible block placement alongside proplace sometimes the block rotation will not work first try and will still validate that wrongful block placement even though it wasnt valid. placing it again however works fixes the issue, but when switching hotbar slots for another type of block it resets that data/info.

@ghost ghost reopened this Jan 9, 2023
Fallen-Breath added a commit that referenced this issue Feb 4, 2023
@Fallen-Breath
better tweakeroo placement tweak compatibility again
fc47e4e 
for #26
we cannot just inject into vanilla ClientPlayerInteractionManager method, otherwise itemstack logics e.g. hand restore will break cuz we might change player's holding item in our logic (commit bf6e0a6)
@Fallen-Breath
Copy link
Owner

Fallen-Breath commented Feb 4, 2023 •
edited

try https://github.com/Fallen-Breath/tweakermore/actions/runs/4092874275

@Fallen-Breath Fallen-Breath added the compatibility Not compatible enough with other mod label Feb 4, 2023
@ghost
Copy link
Author

ghost commented Feb 12, 2023 •
edited by ghost

works good. things like the block not rotating are fixed but the overall warning message isn't. block placement requires you to do 2 inputs before it actually realizes that the input is corrrect.

@Fallen-Breath
Copy link
Owner

works good. things like the block not rotating are fixed but the overall warning message isn't. block placement requires you to do 2 inputs before it actually realizes that the input is corrrect.

any example detailed steps to reproduce?

@ghost
Copy link
Author

ghost commented Feb 13, 2023

works good. things like the block not rotating are fixed but the overall warning message isn't. block placement requires you to do 2 inputs before it actually realizes that the input is corrrect.

any example detailed steps to reproduce?

yeah sure. ill edit a video to show off the visuals of it. i know the reproduction steps but not entirely the cause. ill get to that during editing.

@ghost
Copy link
Author

ghost commented Feb 13, 2023

Alright, done with the editing stuff. so heres the clips of it. I suggest u watch them individually instead of all at once cuz i did some very quick cutting.

clips: https://www.youtube.com/watch?v=c6JZQHWgjY0

and about reproducing it, it appears to be something to do with how things are being executed. whenever u place a block with a direction from my playtesting (observers, pistons, etc..) instead of validating around 60% of the time, it will fail and not properly place the block. it requires the player to try placing the block a second time to realize it's valid. and if the player hotbar slot has not been switched and ur still holding that block that has trouble rotating the issue doesn't happen again. however changing ur hotbar selection will reset it.

adding on to that, the invalid block rotation issue is still there. it's just much less likely to happen now.
in litematica there is a bug report for easyplace which kinda has the same. so maybe it's in relation to litematica pickblock feature?

@Fallen-Breath
Copy link
Owner

Fallen-Breath commented Feb 13, 2023 •
edited

Thanks a lot from the video, so seems like it's the auto pick stuffs, I'll try to fix that

For the invalid block rotation thing, if it's caused by player rotating too fast it's not fix-able with vanilla, because it's just the server-side player rotation has not been updated yet. Maybe sending rotation packet might work but I won't do that cuz it's too hacky for me

@Fallen-Breath
Copy link
Owner

try https://github.com/Fallen-Breath/tweakermore/actions/runs/4165769170

since tweakeroo codes for the placement tweaks stuffs is quite a mess so I can't guarantee the fix can work 100%

@ghost
Copy link
Author

ghost commented Feb 15, 2023

seems to be partially stable now. ill close this for now and will reopen if anything happens.

@ghost ghost closed this as completed Feb 15, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility Not compatible enough with other mod
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fallen-Breath