Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatars not displaying when hostname local HTTP and External URL HTTPS #110

Closed
1 task done
BonzTM opened this issue May 25, 2022 · 1 comment · Fixed by #111
Closed
1 task done

Avatars not displaying when hostname local HTTP and External URL HTTPS #110

BonzTM opened this issue May 25, 2022 · 1 comment · Fixed by #111
Labels
bug Something isn't working

Comments

@BonzTM
Copy link

BonzTM commented May 25, 2022

Description

My Jellyseerr is set up as https://jellyseerr.url via reverseproxy. My Jellyfin instance setup in Jellyseerr initially with http://localP:port, but I have an http://fully.qualified.domainname set as my External URL.

Users in Jellyfin who have an Avatar are missing. The URL is being rewritten to https due to the mixed content, but the hostname is still the internal URL and does not reflect the External URL when set.

Version

v1.1.0

Steps to Reproduce

  1. Set up jellyseer with https scheme hostname
  2. Jellyfin configuration in Jellyseerr set up as http://localip:port
  3. Set up External URL for Jellyfin as https://externalurl
  4. User avatars are missing
  5. User avatars are using hostname, not externalHostname
  6. User avatars are missing because of the HTTPS/HTTP mixed content being rewritten to HTTPS://localip:httpport

Screenshots

image

image

Logs

No response

Platform

desktop

Device

Desktop

Operating System

Windows 11, macOS

Browser

Chrome, Edge, Firefox

Additional Context

? `${settings.jellyfin.hostname}/Users/${account.Id}/Images/Primary/?tag=${account.PrimaryImageTag}&quality=90`

? `${settings.jellyfin.hostname}/Users/${user.Id}/Images/Primary/?tag=${user.PrimaryImageTag}&quality=90`

user.avatar = `${hostname}/Users/${account.User.Id}/Images/Primary/?tag=${account.User.PrimaryImageTag}&quality=90`;

Code of Conduct

  • I agree to follow Overseerr's Code of Conduct
@Fallenbagel Fallenbagel added the bug Something isn't working label May 25, 2022
Fallenbagel added a commit that referenced this issue May 25, 2022
allow avatar url to use externalHostname when setup using local ip

fix #110
Fallenbagel added a commit that referenced this issue May 25, 2022
allow avatar url to use externalHostname when setup using local ip

fix #110
@Fallenbagel
Copy link
Owner

This has been fixed in the new commit to develop branch, you can now set the external hostname in settings and any user that signs in for first time now will use the external hostname and any existing users can be re-imported to update their avatar url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants