Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jellyfinapi): use external api class for jellyfin api requests #762

Merged
merged 7 commits into from
May 25, 2024
Merged

fix(jellyfinapi): use external api class for jellyfin api requests #762

merged 7 commits into from
May 25, 2024

Conversation

Fallenbagel
Copy link
Owner

@Fallenbagel Fallenbagel commented May 23, 2024 •
edited
Loading

Description

This PR refactors jellyfin api requests to be handled by the external api class to be consistent with how other external api requests are made. This refactor would also mean we can easily refactor jellyseerr to use apikeys instead of authtokens. In addition, it would be easier to add axios dns resolution caching

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

@Fallenbagel Fallenbagel mentioned this pull request May 24, 2024
Merged
3 tasks
@github-actions github-actions bot added the merge conflict Cannot merge due to merge conflicts label May 24, 2024
@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@Fallenbagel Fallenbagel changed the title fix(jellyfinapi): use the cacheManager and extend to external api class fix(jellyfinapi): use external api class for jellyfin api requests May 24, 2024
@Fallenbagel
refactor(jellyfinapi): use the external api class for jellyfin api re…
8355686 
…quests

refactors jellyfin api requests to be handled by the external api
to be consistent with how other external api requests are made

related #728, related #387
@github-actions github-actions bot removed the merge conflict Cannot merge due to merge conflicts label May 24, 2024
gauthier-th
gauthier-th reviewed May 24, 2024
View reviewed changes
server/constants/error.ts Outdated Show resolved Hide resolved
.github/workflows/snap.yaml Outdated Show resolved Hide resolved
gauthier-th
gauthier-th requested changes May 25, 2024
View reviewed changes
server/constants/error.ts Outdated Show resolved Hide resolved
@Fallenbagel Fallenbagel merged commit 650c339 into develop May 25, 2024
7 checks passed
@Fallenbagel
Copy link
Owner Author

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauthier-th gauthier-th gauthier-th approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Fallenbagel @gauthier-th