Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Length of undefined on users warnings #875

Conversation

franciscofsales
Copy link
Contributor

Description

On my instance, I was getting a frontend error where the were some issues with trying to check the length of undefined.
I tracked it down to a function that was not completely checking its dependencies and just added a more extensive check that should prevent this issue from happening again.

I didn't find anyone else with the same issue but regardless, this PR is a tiny improvement.

This PR does not change any functionality or affect any of the existing ones

Screenshot (if UI-related)

image

To-Dos

N/A

Issues Fixed or Closed

Could not find anyone experiencing the same issue.

@gauthier-th
Copy link
Collaborator

Could you tell use how to reproduce this issue?

@franciscofsales
Copy link
Contributor Author

Sure, so I run it in the a kuberetes cluster and there's a custom ingress and error handler, this issue happens when the /api/v1/auth/me request does not return the expected 403 response and instead returns something else, which was my cause given that I run https://github.com/tarampampam/error-pages on my setup

Copy link
Collaborator

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gauthier-th gauthier-th mentioned this pull request Jul 19, 2024
1 task
@gauthier-th gauthier-th merged commit c600566 into Fallenbagel:develop Jul 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants