Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine does not compute child node dimensions properly if scene selector element has padding #411

Open
peacechen opened this issue Jul 9, 2015 · 0 comments

Comments

@peacechen
Copy link

When a scene selector element has padding, the engine uses the content size plus padding as the default size for child nodes.

An example may be seen at:
https://github.com/peacechen/famous-carousel

I've worked around the issue by wrapping the scene selector div within another container div. The container div has padding, while the inner scene selector div does not. To more easily see the issue, change the selector in example/index.js from .slideshow to .slideshow-container. Run npm run example to build and run the server.

Notice how .famous-dom-renderer is correctly sized to the container dimensions (sans padding), but the .famous-dom-element slide nodes are sized to the container dimensions with padding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@peacechen and others