Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overloads of GetStringAsync #526

Closed
mungojam opened this issue Feb 14, 2022 · 4 comments · Fixed by #540
Closed

Overloads of GetStringAsync #526

mungojam opened this issue Feb 14, 2022 · 4 comments · Fixed by #540
Labels
enhancement New feature or request

Comments

@mungojam
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The GetStringAsync() extension on HttpClient is exactly what I need, but it's not currently supported with this (super) package

Describe the solution you'd like
I'd like it to work just like the other overloads, taking the AWS credentials as a parameter

Describe alternatives you've considered
I can call GetAsync() instead but then I need to work a bit harder with the response status codes etc.

@mungojam mungojam added the enhancement New feature or request label Feb 14, 2022
@github-actions
Copy link
Contributor

Hi there and welcome to this repository!

A maintainer will be with you shortly, but first and foremost I would like to thank you for taking the time to report this issue. Quality is of the highest priority for us, and we would never release anything with known defects. We aim to do our best but unfortunately you are here because you encountered something we didn't expect. Lets see if we can figure out what went wrong and provide a remedy for it.

@FantasticFiasco
Copy link
Owner

I can look into what it would take to implement these overloads, but I cannot start until next week. I'll get back to you when I know more.

@FantasticFiasco
Copy link
Owner

Hi @mungojam.

When retrospecting regarding what I've been up to this year I unfortunately have to tell you that my engagements with my day-to-day employer has ramped up in intensity. I will still be able to keep my projects up-to-date regarding security issues and external dependencies due to automation, but even though I would love to implement this feature, because I think it's a good one that will increase the value of this project, I cannot give you a deadline, nor promise you that I ever will find the time to implement it.

Looking at alternatives, are you able to contribute the code to this project? Or are you working for a company that is making money and have the option to fund this project?

@mungojam mungojam changed the title Overloads of GetStringAsync etc. Overloads of GetStringAsync Mar 13, 2022
FantasticFiasco pushed a commit that referenced this issue Mar 18, 2022
@FantasticFiasco
Copy link
Owner

A new version has now been released. Thank you for the contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants