Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FilterIndex after Open/Save File Dialogs close #49

Closed
ericdc66 opened this issue Oct 26, 2018 · 7 comments · Fixed by #50
Closed

Update FilterIndex after Open/Save File Dialogs close #49

ericdc66 opened this issue Oct 26, 2018 · 7 comments · Fixed by #50
Labels
bug Something isn't working

Comments

@ericdc66
Copy link

Version 4.1.1 added the feature to set FilterIndex in response to Issue #25.

We also need the FilterIndex to be set when the Open/Save File Dialogs close, similar to how the FileName and FileNames are set in the ShowDialog methods of those Wrappers.

In our case the filter options specify different export formats to an Excel spreadsheet. Since the extension is the same (*.xlsx), the selected FilterIndex is used to determine the export format to use.
@FantasticFiasco
Copy link
Owner

Let me look into it. If it as straightforward as #25 it is a easy fix, if it isn't we'll have to look at alternate implementations.

Thanks for reporting the issue!

@FantasticFiasco
Copy link
Owner

I think we should classify the behavior as a bug. Clearly the filter index should follow the same behavior as the the selected file name(s).

If I fix the bug, would you be willing to verify it using a pre-release before I publish the fix in a official release?

@FantasticFiasco FantasticFiasco added the bug Something isn't working label Oct 26, 2018
@ericdc66
Copy link
Author

Yes, I can test a pre-release version.

@FantasticFiasco
Copy link
Owner

I will start the work tonight, but even though it isn't much to change, I can't have anything for you until in two days due to priorities, so don't expect anything until then.

Have a nice weekend!

@FantasticFiasco FantasticFiasco mentioned this issue Oct 28, 2018
Merged
@FantasticFiasco
Copy link
Owner

Please try the following package and let me know if it solves your issue.

@ericdc66
Copy link
Author

I tested the Open and Save File Dialogs in the Net version. The FilterIndex in the settings classes changed as expected. I did not test the UWP version.

FantasticFiasco added a commit that referenced this issue Oct 30, 2018
@FantasticFiasco
fix: FilterIndex of open and save file dialog
2b34724 
Update `FilterIndex` when open and save file dialog closes. This
enables the caller to identify the filter index used in the dialog.

Closes #49
FantasticFiasco added a commit that referenced this issue Oct 30, 2018
@FantasticFiasco
fix: FilterIndex of open and save file dialog (#50)
472612f 
Update `FilterIndex` when open and save file dialog closes. This
enables the caller to identify the filter index used in the dialog.

Closes #49
@FantasticFiasco
Copy link
Owner

The official package is live on NuGet, thank you for reporting this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update FilterIndex after Open/Save File Dialogs close FantasticFiasco/mvvm-dialogs
2 participants
@FantasticFiasco @ericdc66