Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize gen-deleted-accounts #1085

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

matejmode
Copy link
Collaborator

@matejmode matejmode commented Apr 22, 2024

Description

Make deletion-db generation parallel to make it faster. To keep correct order worker tasks and results are distributed in round-robin logic.

Fixes # (issue)
generation of deletion-db for #902

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Adds or updates testing

@matejmode matejmode marked this pull request as ready for review April 22, 2024 13:20
utildb/gen_deleted_accounts.go Outdated Show resolved Hide resolved
utildb/gen_deleted_accounts.go Show resolved Hide resolved
utildb/gen_deleted_accounts.go Outdated Show resolved Hide resolved
utildb/gen_deleted_accounts.go Outdated Show resolved Hide resolved
utildb/gen_deleted_accounts.go Outdated Show resolved Hide resolved
utildb/gen_deleted_accounts_test.go Outdated Show resolved Hide resolved
utildb/gen_deleted_accounts_test.go Outdated Show resolved Hide resolved
utildb/gen_deleted_accounts_test.go Show resolved Hide resolved
utildb/gen_deleted_accounts_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@petr-hanzl petr-hanzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wsodsong
Copy link
Collaborator

wsodsong commented May 8, 2024

Please rebase to the latest develop branch.

@wsodsong wsodsong force-pushed the matej/gen-deleted-account-optimize branch from cb765b8 to d0f9c68 Compare May 21, 2024 07:37
@wsodsong wsodsong force-pushed the matej/gen-deleted-account-optimize branch from d0f9c68 to 943c4d9 Compare May 21, 2024 09:28
@wsodsong
Copy link
Collaborator

Wait for a manual test on GCP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants