Refactor config value retrieval #913
Draft
+265
−209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsodsong
requested changes
Dec 14, 2023
There was a problem hiding this comment.
Looks good! Let's also add a simple test case checking whether createConfigFromFlags returns value as expected. Should @Lubomir-Jahn help you with this?
Comment on lines
+118
to
+120
| if isSpecified { | ||
| specifiedFlags[flagName] = true | ||
| } |
There was a problem hiding this comment.
Suggested change
| if isSpecified { | |
| specifiedFlags[flagName] = true | |
| } | |
| specifiedFlags[flagName] = isSpecified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is (currently) PROOF OF CONCEPT (tests are missing). The config could be rewritten so that it is more modular.
After this change of structure we can print just the relevant values for the command printing only the flags which are actually used by it. It could be done by iterating over
specifiedFlagsAida/utils/config.go
Line 633 in bff9c34
There could either be generic message for each config value or there could be a map with predefined notifications.
@Lubomir-Jahn what do you think? If it works could you please expand on my initial work and finish this off?
Issues
This will solve #886 for not just
chainidbut for every flag.Type of change