This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
LRU-based ordering buffer #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
devintegral2
commented
Sep 17, 2019
devintegral2
commented
- ordering buffer: use LRU instead of time-based GC. It guarantees that no more than N events are stored in RAM
- event checks: time check against self-parent
- fix races, refactor
devintegral2
requested review from
andrecronje and
devintegral
as code owners
devintegral
pushed a commit
that referenced
this pull request
Sep 17, 2019
Merge pull request #327 from devintegral2/feature/lru_ordering
quan8
reviewed
Sep 17, 2019
| @@ -169,8 +165,8 @@ func (p *Poset) processKnownRoots() *election.ElectionRes { | |||
| // Event order matter: parents first. | |||
| // ProcessEvent is not safe for concurrent use. | |||
| func (p *Poset) ProcessEvent(e *inter.Event) error { | |||
| if e.Epoch != p.EpochN { | |||
| return epoch_check.ErrNotRecent | |||
| if err := epoch_check.New(&p.dag, p).Validate(e); err != nil { | |||
There was a problem hiding this comment.
consider to cache an epochCheck (epoch_check.New(&p.dag, p)) per poset.
Line 58, 168: epoch_check.New(&p.dag, p).Validate(e) => possibly store a local boolean in the poset for e, if validation takes time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.