This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
Gossip DB fault tolerance #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfxdxdev
requested review from
andrecronje,
devintegral and
devintegral2
as code owners
golangcibot
reviewed
Oct 3, 2019
gossip/store.go
Outdated
| // setDirty sets dirty flag. | ||
| func (s *Store) setDirty(flag bool) { | ||
| key := []byte("is_dirty") | ||
| val := make([]byte, 1, 1) |
There was a problem hiding this comment.
S1019: should use make([]byte, 1) instead (from gosimple)
… flushable.SyncedPool syncs flush of flushables
golangcibot
reviewed
Oct 7, 2019
kvdb/flushable/synced_pool.go
Outdated
| if prevId == nil { | ||
| prevId = &mark | ||
| } | ||
| if bytes.Compare(mark, *prevId) != 0 { |
There was a problem hiding this comment.
S1004: should use !bytes.Equal(mark, *prevId) instead (from gosimple)
quan8
reviewed
Oct 8, 2019
| @@ -188,7 +188,7 @@ func (p *Poset) ProcessEvent(e *inter.Event) (err error) { | |||
| if err != nil { | |||
There was a problem hiding this comment.
- remove defer func and move the commit to the end.
- on err, add a debug log instead of quietly return.
quan8
reviewed
Oct 8, 2019
gossip/store.go
Outdated
| s.Log.Crit("Failed to get value", "err", err) | ||
| } | ||
|
|
||
| return len(val) > 1 && val[0] != 0 |
quan8
reviewed
Oct 8, 2019
kvdb/super_db/super_db.go
Outdated
| @@ -226,8 +257,11 @@ func (sdb *SuperDb) FlushIfNeeded(id hash.Event) bool { | |||
|
|
|||
| // call on startup, after all dbs are registered | |||
| func (sdb *SuperDb) CheckDbsSynced() error { | |||
There was a problem hiding this comment.
- add comment to the function.
- Compare the flag values across barDbs?
quan8
reviewed
Oct 8, 2019
kvdb/super_db/super_db.go
Outdated
| key := []byte("flag") | ||
| var prevId *hash.Event | ||
| var prevId *[]byte | ||
| for _, db := range sdb.bareDbs { | ||
| mark, err := db.Get(key) |
quan8
reviewed
Oct 8, 2019
kvdb/super_db/super_db.go
Outdated
| } | ||
|
|
||
| func (sdb *SuperDb) DropDb(name string) { | ||
| if db := sdb.bareDbs[name]; db == nil { |
golangcibot
reviewed
Oct 9, 2019
| defer func() { | ||
| if err != nil { | ||
| return | ||
| } | ||
| err = p.store.Commit() | ||
| immediately := (p.EpochN != was) |
There was a problem hiding this comment.
ineffectual assignment to immediately (from ineffassign)
devintegral
pushed a commit
that referenced
this pull request
Oct 9, 2019
Merge pull request #344 from sfxdxdev/gossip-fault-tolerance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits whole DB after event connecting.
Detects DB-dirty flag on start.