-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizable genesis files #271
Customizable genesis files #271
Conversation
- genesis is self-hashed, making it secure to read from non-trusted source - genesis content uses .zip format and doesn't require O(n) pre-decoding - user may choose different genesis files for different purpose (e.g. archive, snapsync-only with blocks history, snapsync-only with no history)
@uprendis Will we include below branch also into this PR? https://github.com/uprendis/go-opera/commits/feature/add-fileshash-tests |
Sure, I thought we'll add it after this PR. You can make a PR straight into this branch feature/customizable-genesis-file |
okay just thought you forgot to include it into this PR. If you have plan to add it later after this PR then it's fine. |
@uprendis what kind of manual testing scenarios should be performed to ensure your code works as expected? |
Here's the interface:
I may suggest such testcases:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I suggest to add some testing since it is a big PR.
Rework genesis file format and genesis processing:
Other changes: