Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Management commands should inherit from BaseCommand (instead of NoArgsCommand) #460

Closed
bittner opened this issue Jan 7, 2016 · 0 comments
Closed

Management commands should inherit from BaseCommand (instead of NoArgsCommand) #460

bittner opened this issue Jan 7, 2016 · 0 comments
Labels
Improvement

Comments

@bittner
Copy link
Contributor

bittner commented Jan 7, 2016

Zinnia has two management commands that inherit from NoArgsCommand:

  1. spam_cleanup
  2. count_discussions

NoArgsCommand is deprecated since Django 1.8, and management commands should now inherit from BaseCommand instead according to Django's documentation.
@bittner bittner changed the title Inherit management commands from BaseCommand (instead of NoArgsCommand) Management commands should inherit from BaseCommand (instead of NoArgsCommand) Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fantomas42 @bittner