Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Issue: Execute the exe file when opening a file with same filename without file extension #428

Closed
zeze-zeze opened this issue Jul 31, 2021 · 1 comment
Assignees
Labels

Comments

@zeze-zeze
Copy link

zeze-zeze commented Jul 31, 2021

Hi, we are security researchers from Taiwan.
Here are our github: https://github.com/zeze-zeze、https://github.com/hsuck

Environment:
OS: Windows10 1709
FarManager: v3.0.5861.2321

Reproduce:

  1. Place a file in a directory
  2. Place an another file with the same filename, but with extension name exe
  3. Open FarManager.exe and navigate to the directory
  4. Move to the file without extension (not exe) and press enter, and it will execute the exe

Reason:
The project uses Windows API ShellExecute, which executes the exe with the same filename when opening a file without extension by default.

Possible Fix:
I think it should not be the default functionality for the project to do so.
As CVE-2020-35112, it should be handled whenever opening a file without extension, the program will open the explorer toward the file.

Demo Video:
https://drive.google.com/file/d/1RlDF_D8LFRnRLPA5yG_5SKDbII2KLYaL/view?usp=sharing

alabuzhev added a commit that referenced this issue Jul 31, 2021
1. gh-428: Security Issue: Execute the exe file when opening a file with same filename without file extension.
2. Correctly show the shell type (if any) for files without extension.
@alabuzhev
Copy link
Contributor

Hi, thanks for your report.
Should be fixed in 5862 / eaa9244.

@alabuzhev alabuzhev self-assigned this Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants