Temporarily pin pydantic<2 to fix PyBaMM build
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 9 9
Lines 257 257
=======================================
Hits 248 248
Misses 9 9 ☔ View full report in Codecov by Sentry. |
|
Should Python 3.11 be added to the CI matrix too? I have been trying to add updates and breaking changes for Pydantic V2. The new version also carries over a backport of Pydantic V1 so we can import older functionality and implement newer changes incrementally |
|
Thanks @arjxn-py, will merge this now! @agriyakhetarpal yes, let's add 3.11. If you see anything that could be improved on the CI then please go ahead and make a PR. |
rtimms
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.