Fixing vcc telem parse #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 6, 2017 00:08
Renamed the ADC parsing dictionary ADC6 to VCC.
Fixed parsing offset error. Found that the data was not correct and fixed per issue #25
kb1lqc
reviewed
Jan 7, 2017
| 'ADC3': telemetryList[28], | ||
| 'ADC4': telemetryList[29], | ||
| 'ADC5': telemetryList[30], | ||
| 'VCC': telemetryList[31], |
There was a problem hiding this comment.
OK looks like ADC6 is VCC and ADC7 is boardtemp. Thanks for catching this.
kb1lqc
reviewed
Jan 7, 2017
| 'SOURCEID': int(telemetryList[2]), | ||
| 'DESTINATIONCALLSIGN': telemetryList[3], | ||
| 'DESTINATIONCALLSIGNLEN': telemetryList[4], | ||
| 'DESTINATIONID': telemetryList[5], |
There was a problem hiding this comment.
OK you previously would delete index items 1 and 3. Adding it back them would in-fact change the indexing when parsing into a dictionary. These changes would add two to the index for items afterwards which appears correct. No longer deleting item 31 would push any item afterwards upwards by three which appears correct.
kb1lqc
approved these changes
Jan 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains