WIP: Move seed to reset() #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_autodep added autodeprication code and fixed docs
|
I started looking at this, and the number of remaining changes requires here is significant. Especially the vector environments need to be rethought pretty thoroughly. |
|
Basically, we need to decide how this seed argument to reset operates in vector environments. I assume this will also have to align with however gym does it. |
|
Looks like the gym implementation is finished: https://github.com/openai/gym/blob/master/gym/vector/sync_vector_env.py#L89 |
|
Hi @elbamos, how's this PR going on? |
|
Closing becuase #146 deals with this already |
|
This issue has been dealt with anyway as per the previous comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP in support of a related PR on PettingZoo. I expect this to fail tests since neither PettingZoo nor Gym has been updated to have the seed parameter on the reset function.