Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): add metadata to bag item and requests types #685

Merged
merged 1 commit into from
Mar 1, 2023
Merged

feat(client): add metadata to bag item and requests types #685

merged 1 commit into from
Mar 1, 2023

Conversation

anapim
Copy link

@anapim anapim commented Feb 27, 2023

Description

This adds the property metadata to bag item and respective requests types.

Dependencies

Checklist

  • The commit message follows our guidelines
  • Tests for the respective changes have been added
  • The code is commented, particularly in hard-to-understand areas
  • The labels and/or milestones were added

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@anapim anapim added this to the 💎 Blackout 2.0 milestone Feb 27, 2023
@github-actions github-actions bot added the 📦 client Relative to the `@farfetch/blackout-client` package label Feb 27, 2023
@anapim anapim force-pushed the feat_add-metadata-to-bag-requests branch from 091c2c6 to b988990 Compare February 28, 2023 10:28
feat(client): add metadata to bag item and requests types
af463b4 
This adds the property `metadata` to bag item and respective requests
types.
@anapim anapim force-pushed the feat_add-metadata-to-bag-requests branch from b988990 to af463b4 Compare March 1, 2023 17:10
@edmundofreitas edmundofreitas merged commit d2959c9 into next Mar 1, 2023
@edmundofreitas edmundofreitas deleted the feat_add-metadata-to-bag-requests branch March 1, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boliveira boliveira boliveira approved these changes

@edmundofreitas edmundofreitas edmundofreitas approved these changes

@nelsonleite nelsonleite nelsonleite approved these changes

@tiagodicosta tiagodicosta tiagodicosta approved these changes

@andrevechina andrevechina Awaiting requested review from andrevechina

@danpadrinom danpadrinom Awaiting requested review from danpadrinom

@ivomota ivomota Awaiting requested review from ivomota

@rc23 rc23 Awaiting requested review from rc23

Assignees
No one assigned
Labels
📦 client Relative to the `@farfetch/blackout-client` package
Milestone
💎 Blackout 2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anapim @boliveira @nelsonleite @tiagodicosta @edmundofreitas