-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres support #108
Postgres support #108
Conversation
… tables, unified columns casing
Would appreciate Your review @luispfgarces @filipeesch @fernando-a-marins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation seems to be very alike the SQL Server implementation. Many of the things are duplicated, but I agree that this could not be accomplished without doing it (at least without a structural refactor).
I am leaving just 2 comments on minor things to solve, nothing that poses a big deal. Thank you @alek-talabat for your contribution. On my end, I'll approve once you fix those 👌
src/KafkaFlow.Retry.IntegrationTests/Core/Bootstrappers/BootstrapperKafka.cs
Outdated
Show resolved
Hide resolved
src/KafkaFlow.Retry.Postgres/Repositories/RetryQueueItemRepository.cs
Outdated
Show resolved
Hide resolved
We need to merge #93 to fix the build pipeline (support for builds with forked repositories). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your changes @alek-talabat. LGTM
@alek-talabat the PR #93 was merged, which will fix your build pipeline. Please merge from main branch. |
Hi @alek-talabat,
|
@alek-talabat the sample can be a different PR. And by the way, excellent contribution right here! 👏 |
# Conflicts: # README.md
@alek-talabat can you please check the build error?
I think that the pull request that went Live before yours created a new method on the repository interface, which yours does not have (because you implemented it before this change). Thank you! 🙏 |
Sorry for the delay, but changes from the most recent master are already included. Would appreciate Your reviews @martinhonovais @gsferreira to have this one closed |
This reverts commit 20b242d.
Description
Added postgres support to kafkaflow-retry-extensions based on the implementation for sql server. It's needed to enable using the package with postgres db. Decided to make it as similar as possible to sql code, to make sure it's aligned to the existing style & practices and does not cause any discrepancies. Further adjustments of extracting shared code could be done in separate PRs, after confirming it with the repo owners. All of the postgres adjustments (comparing to sql code/scripts) can be viewed by skipping first commit
How Has This Been Tested?
Run all unit tests and integration tests locally to make sure that new integration works. New integration is covered same way as sql server
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement