Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in middlewares.md - InvalidOperationException incorrectly spelled with lowercase 'o' #531

Merged

Conversation

danielmpetrov
Copy link
Contributor

Description

Hi, I discovered your library recently and was going through the docs and copying examples, and found a small typo which makes the sample code not compile.

How Has This Been Tested?

Copied the correct name from Visual Studio.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@danielmpetrov danielmpetrov changed the title Fix typo in middlewares.md - InvalidOperationException incorrectly spelled with lowercase 'o Fix typo in middlewares.md - InvalidOperationException incorrectly spelled with lowercase 'o' Feb 22, 2024
@joelfoliveira
Copy link
Contributor

Hi @danielmpetrov ,

Thank you for your contribution. Can you please amend the commit message to follow the conventional commits as per the contribution guidelines, otherwise the CI pipeline won't pass.

@danielmpetrov
Copy link
Contributor Author

Sorry about that, I glossed over the conventional commits section. I will fix this later today.

@danielmpetrov danielmpetrov changed the title Fix typo in middlewares.md - InvalidOperationException incorrectly spelled with lowercase 'o' docs: fix typo in middlewares.md - InvalidOperationException incorrectly spelled with lowercase 'o' Feb 23, 2024
@joelfoliveira joelfoliveira merged commit fcd2eda into Farfetch:master Feb 26, 2024
3 checks passed
@danielmpetrov danielmpetrov deleted the feature/typo-middleware-docs branch February 26, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants