Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct "Open Data Folder" behaviour #9

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

guilherme-fh
Copy link
Contributor

PR Details

Correct behaviour for the "Open Data Folder" button on the settings screen after the changes made to the working directory

Description

When pressing the "Open Data Folder", Mockingbird now opens the working directory instead of its main directory as it was previously

Motivation and Context

Correct behaviour that was incorrect after the changes in 1.2.0

How Has This Been Tested

Ran the Mockingbird app and tested the behaviour before and after the changes

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@erickjung erickjung merged commit 1c1895a into Farfetch:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants