feat: remove logs when NODE_ENV != development

Farfetch · Sep 1, 2020 · 4443d51 · 4443d51
1 parent 4149ec8
commit 4443d51
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 15 deletions.
diff --git a/src/ResponsiveProvider.js b/src/ResponsiveProvider.js
@@ -115,7 +115,7 @@ const ResponsiveProvider = ({
     );
 
     useEffect(() => {
-        if (!process || !process.env || process.env.NODE_ENV !== 'test') {
+        if (process && process.env && process.env.NODE_ENV === 'development') {
             /* eslint-disable no-console */
             console.group(
                 '%c @farfetch/react-context-responsive updated!',

diff --git a/tests/ResponsiveProvider.test.js b/tests/ResponsiveProvider.test.js
@@ -152,23 +152,30 @@ describe('<ResponsiveProvider />', () => {
         expect(listenersRemovedAfterUnmount).toBe(listenersAdded);
     });
 
-    test('should not call console.log in the test environment', () => {
-        window.resizeTo(1024, 768);
+    test.each(
+        ['production', 'test'],
+        'should not call console.log in the % environment',
+        (env) => {
+            process.env.NODE_ENV = env;
+            window.resizeTo(1024, 768);
 
-        render(
-            <ResponsiveProvider {...props}>
-                <div>Test</div>
-            </ResponsiveProvider>
-        );
+            render(
+                <ResponsiveProvider {...props}>
+                    <div>Test</div>
+                </ResponsiveProvider>
+            );
 
-        expect(global.console.group).not.toHaveBeenCalled();
-        expect(global.console.log).not.toHaveBeenCalled();
-        expect(global.console.groupEnd).not.toHaveBeenCalled();
-    });
+            expect(global.console.group).not.toHaveBeenCalled();
+            expect(global.console.log).not.toHaveBeenCalled();
+            expect(global.console.groupEnd).not.toHaveBeenCalled();
+
+            // Clean the global changes
+            process.env.NODE_ENV = 'test';
+        }
+    );
 
-    test('should call console.log only outside the test environment', () => {
-        // Set this as prod environment
-        process.env.NODE_ENV = 'dev';
+    test('should call console.log only for development environment', () => {
+        process.env.NODE_ENV = 'development';
         window.resizeTo(1024, 768);
 
         const { unmount } = render(