feat: able to update rules date end and disable #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosgoias
requested review from
luispfgarces,
brunohfgomes,
Daniel-C-Dias,
fernando-a-marins,
jdromeiro,
jorgedgodinho,
martinhonovais,
rodrigobelo,
sergioamribeiro and
spookylsm
spookylsm
previously approved these changes
Feb 1, 2023
spookylsm
previously approved these changes
Feb 1, 2023
jdromeiro
reviewed
Feb 3, 2023
tests/Rules.Framework.IntegrationTests/InMemoryRulesDataSource.cs
Outdated
Show resolved
Hide resolved
carlosgoias
requested review from
jdromeiro and
spookylsm
and removed request for
rodrigobelo
jdromeiro
previously approved these changes
Feb 14, 2023
isabelneto
previously approved these changes
Feb 14, 2023
carlosgoias
dismissed stale reviews from isabelneto and jdromeiro
via
409d36b
carlosgoias
changed the title
carlosgoias
requested review from
luispfgarces
and removed request for
isabelneto
jdromeiro
requested changes
Apr 19, 2023
src/Rules.Framework/Providers/InMemory/DataModel/RuleDataModel.cs
Outdated
Show resolved
Hide resolved
...ders.InMemory.IntegrationTests/Features/RulesEngine/RulesMatching/RulesUpdateDateEndTests.cs
Outdated
Show resolved
Hide resolved
...iders.MongoDb.IntegrationTests/Features/RulesEngine/RulesMatching/RulesUpdateDateEndTests.cs
Outdated
Show resolved
Hide resolved
luispfgarces
requested changes
May 9, 2023
src/Rules.Framework/Evaluation/Compiled/CompilationRulesSourceMiddleware.cs
Show resolved
Hide resolved
src/Rules.Framework/Providers/InMemory/InMemoryProviderRulesDataSource.cs
Outdated
Show resolved
Hide resolved
tests/Rules.Framework.IntegrationTests/InMemoryRulesDataSource.cs
Outdated
Show resolved
Hide resolved
jdromeiro
previously approved these changes
May 10, 2023
luispfgarces
requested changes
May 11, 2023
src/Rules.Framework.Providers.MongoDb/MongoDbProviderRulesDataSource.cs
Outdated
Show resolved
Hide resolved
luispfgarces
approved these changes
May 11, 2023
spookylsm
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Able to update rules' date end in order to change or deactivate the rule (#115)
Change checklist
Please also check the I want to contribute guidelines and make sure you have done accordingly.
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement