Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArgumentNullException for InMemoryRulesStorage from IServiceCollection #142

Conversation

luispfgarces
Copy link
Contributor

@luispfgarces luispfgarces commented May 7, 2023

Description

  • Fixes extension method for in-memory rules data source using IServiceCollection.
  • Fixes all integration tests to use in-memory rules data source provider instead of a simpler implementation embedded in tests (which was removed).
  • Changes the namespaces of the extension methods for configuring the in-memory rules data source (for simplicity of the consumers of Rules.Framework).
  • Refactors unit tests for the in-memory data source provider, by moving them to the Rules.Framework.Tests project. Also, converted the touched files to use var as per convention.

The integration tests for the in-memory data source provider are also candidates for moving to project Rules.Framework.IntegrationTests, but I intentionally left that for another time.

Closes #141.

Change checklist

  • Code follows the code rules guidelines of this project
  • Commit messages follow the commit rules of this project
  • I have self-reviewed my changes before submitting this pull request
  • I have covered new/changed code with new tests and/or adjusted existent ones
  • I have made changes necessary to update the documentation accordingly

Please also check the I want to contribute guidelines and make sure you have done accordingly.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@luispfgarces luispfgarces self-assigned this May 7, 2023
jdromeiro
jdromeiro previously approved these changes May 9, 2023
carlosgoias
carlosgoias previously approved these changes May 12, 2023
@luispfgarces luispfgarces dismissed stale reviews from carlosgoias and jdromeiro via f25f851 May 12, 2023 11:23
@luispfgarces
Copy link
Contributor Author

@carlosgoias @jdromeiro can you please review it again? Unfortunately, I had to resolve merge conflicts from master.

@luispfgarces
Copy link
Contributor Author

@jdromeiro can you please review this again?

@luispfgarces luispfgarces merged commit 2bd7246 into master May 19, 2023
2 checks passed
@luispfgarces luispfgarces deleted the bug/141/fix_argumentnullexception_for_inmemoryrulesstorage_from_servicecollection branch May 19, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants