-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ArgumentNullException for InMemoryRulesStorage from IServiceCollection #142
Merged
luispfgarces
merged 7 commits into
master
from
bug/141/fix_argumentnullexception_for_inmemoryrulesstorage_from_servicecollection
May 19, 2023
Merged
Fix ArgumentNullException for InMemoryRulesStorage from IServiceCollection #142
luispfgarces
merged 7 commits into
master
from
bug/141/fix_argumentnullexception_for_inmemoryrulesstorage_from_servicecollection
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in-memory rules storage
jdromeiro
previously approved these changes
May 9, 2023
carlosgoias
previously approved these changes
May 12, 2023
…moryrulesstorage_from_servicecollection
@carlosgoias @jdromeiro can you please review it again? Unfortunately, I had to resolve merge conflicts from master. |
carlosgoias
approved these changes
May 12, 2023
@jdromeiro can you please review this again? |
jdromeiro
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IServiceCollection
.var
as per convention.The integration tests for the in-memory data source provider are also candidates for moving to project Rules.Framework.IntegrationTests, but I intentionally left that for another time.
Closes #141.
Change checklist
Please also check the I want to contribute guidelines and make sure you have done accordingly.
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement