Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor benchmarks scenarios for reuse as test scenarios #144

Merged

Conversation

luispfgarces
Copy link
Contributor

Description

  • Moved the benchmarks scenarios from the benchmarks project to the integration tests common project, so that those scenarios can be re-used on integration tests.
  • Created an integration test for the scenario that uses Texas Hold'em Poker combinations.
  • Added logic to benchmarks so that they can be run via the command line (future PR). Also added logic to complement the information gathered when running benchmarks on a Windows OS.

Change checklist

  • Code follows the code rules guidelines of this project
  • Commit messages follow the commit rules of this project
  • I have self-reviewed my changes before submitting this pull request
  • I have covered new/changed code with new tests and/or adjusted existent ones
  • I have made changes necessary to update the documentation accordingly

Please also check the I want to contribute guidelines and make sure you have done accordingly.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

carlosgoias
carlosgoias previously approved these changes May 9, 2023
carlosgoias
carlosgoias previously approved these changes May 12, 2023
@luispfgarces luispfgarces dismissed stale reviews from jdromeiro and carlosgoias via 0bda7e5 May 24, 2023 11:20
@luispfgarces
Copy link
Contributor Author

@jdromeiro and @carlosgoias can you please review again? I have also refactored the RulesFromJson class used at integration tests to use the new fluent API to build the conditions.

@jdromeiro jdromeiro merged commit cc5559b into master May 25, 2023
2 checks passed
@luispfgarces luispfgarces moved this from Current to Done in Rules framework roadmap Jul 24, 2023
@luispfgarces luispfgarces deleted the refactor_benchmarks_scenarios_for_reuse_as_test_scenarios branch March 22, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance & refactoring Restructure the codebase without altering functionality
Development

Successfully merging this pull request may close these issues.

None yet

3 participants