Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operators.In and Operators.NotIn with not working properly when trying to match the rule setting the condition value as null #149

Conversation

isabelneto
Copy link
Contributor

@isabelneto isabelneto commented Jun 1, 2023

Description

The problem with the IN and NOT IN operators when trying to match the rule by setting the condition value to null had as its root cause the fact that the default values defined for the array types were an empty array and should be its elementary types.

Fixed defaults for array types to the elementary types (int, decimal, bool and string).

Closes #130

Change checklist

  • Code follows the code rules guidelines of this project
  • Commit messages follow the commit rules of this project
  • I have self-reviewed my changes before submitting this pull request
  • I have covered new/changed code with new tests and/or adjusted existent ones
  • I have made changes necessary to update the documentation accordingly

Please also check the I want to contribute guidelines and make sure you have done accordingly.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

Copy link
Contributor

@luispfgarces luispfgarces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be OK by me (I tested it locally to understand your resolution). It seems to me then that we don't really need to differentiate DataTypes from String and ArrayString (and the other ones). But we can look into that another time, this definitely solves the problem and I think nothing else is required 👌

@jdromeiro jdromeiro merged commit df38127 into master Jun 12, 2023
2 checks passed
@luispfgarces luispfgarces deleted the feat/130/operators_in_and_operators_notin_with_not_working_properly_when_trying_to_match_the_rule_setting_the_condition_value_as_null branch March 22, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants