Bottom Gap after keyboard hidden

[IronLady]

Issue Description

Seems like there is some gap after keyboard close. Before and while keyboard showing, there is no gap.

1. Before keyboard shown
   

2. Keyboard shown
   

3. Keyboard hidden
   

Steps to Reproduce / Code Snippets

<SafeAreaView style={styles.androidSafeArea}>
    <GiftedChat
        messages={this.state.messages} 
        onSend={messages => this.onSend(messages)}
        user={{
        _id: 1,
        }} />
    <KeyboardAvoidingView behavior={'padding'} keyboardVerticalOffset={80}/>
</SafeAreaView>

Expected Results

There is no gap below the text input bar. Just like the 1st screenshot

Additional Information

• Nodejs version: 8
• React version: 16.9.0
• Expo React Native version: 36.0.0
• react-native-gifted-chat version: 0.13.0
• Platform(s) (iOS, Android, or both?): Android 9

[technoplato]

I realize this is on Android, but possible dupe of #1306

[msqar]

@IronLady Were you able to solve it? I just see this post of yours, it happens for instance on my iPhone XS, it looks ugly, i'd like to make it fill down the bottom too.

[IronLady]

@msqar Not yet. I can't find the issue. Is it really happening in iOS too?

[msqar]

@IronLady yes, i created an issue for this on iOS yesterday. Here it is so you can keep track of it if you'd like #1624

Also, I noticed that if you minimize the app while the chat keyboard is opened, and go back in to the app, it adds an extra gap between input and keyboard, you need to close the keyboard, open it back and the gap is gone... it's a pretty weird bug.

[msqar]

@IronLady ended up fixing it myself by again, modifying GiftChat code. I have a local forked version with all my custom modifications. Had to remove the SafeAreaView and handle every case with isIphoneX() to set different heights of input toolbox and also the overall container height to prevent overlapping between message container and input toolbar. I suggest you doing the same, otherwise it will be a looong wait until something gets released in master.

[technoplato]

Any chance you could post that code?

…

On Tue, Jan 28, 2020 at 10:29 AM msqar ***@***.***> wrote: @IronLady <https://github.com/IronLady> ended up fixing it myself by again, modifying GiftChat code. I have a local forked version with all my custom modifications. Had to remove the SafeAreaView and handle every case with isIphoneX() to set different heights of input toolbox and also the overall container height to prevent overlapping between message container and input toolbar. I suggest you doing the same, otherwise it will be a looong wait until something gets released in master. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1614?email_source=notifications&email_token=ABU2FGFE5M6QOOUENX7C463RABFMPA5CNFSM4KISZM2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKDW4WI#issuecomment-579300953>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABU2FGBG5HBDEAEEH4QARQTRABFMPANCNFSM4KISZM2A> .

[msqar]

@technoplato sure but how can i share all those files? i did modifications to some files, i added stuff like when top is reached i automatically load more messages instead of having to press the button, added the scrollToBottom to work along the feature i just mentioned otherwise both wouldn't work at the same time, and i also fixed the iPhoneX marginBottom and now it works on Android/iOS. I can't tell you exactly where i did these changes as i made them not all at once, I kept working on my own version of it.

This is how it looks now for me on iPhone XS:

[technoplato]

If they’re in git, you can just push them to a repo of your own and link us. We can look at the diffs from there. If not in git, you could add them to git and push them up. We’d just have to sort through differences with a different strategy.

…

On Tue, Jan 28, 2020 at 6:27 PM msqar ***@***.***> wrote: @technoplato <https://github.com/technoplato> sure but how can i share all those files? i did modifications to some files, i added stuff like when top is reached i automatically load more messages instead of having to press the button, added the scrollToBottom to work along the feature i just mentioned otherwise both wouldn't work at the same time, and i also fixed the iPhoneX marginBottom and now it works on Android/iOS. I can't tell you exactly where i did these changes as i made them not all at once, I kept working on my own version of it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1614?email_source=notifications&email_token=ABU2FGDH2TGYMTG4HY35JILRAC5O7A5CNFSM4KISZM2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKFM4AI#issuecomment-579522049>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABU2FGGXDADQGQTAMP7TWKTRAC5O7ANCNFSM4KISZM2A> .

[shamilovtim]

@msqar you should move your changes to a fork of this project so that:

1. you could make a pull request and contribute to this project
2. (most importantly) the next time you npm install your changes will be overwritten permanently. they should be stored in git on a new branch off of master in your fork.

[shamilovtim]

if you search existing issues you will see issues relevant to the fact that you've nested your entire project in a Safeareaview but this project provides its own Safeareview. People have already encountered and worked around this and you can consult their solutions

[technoplato]

Well that definitely seems simpler. Will try, thanks Timothy.

…

On Wed, Jan 29, 2020 at 12:08 AM Timothy Shamilov ***@***.***> wrote: if you search existing issues you will see issues relevant to the fact that you've nested your entire project in a Safeareaview but this project provides its own Safeareview. People have already encountered and worked around this and you can consult their solutions — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1614?email_source=notifications&email_token=ABU2FGD45HLGVZ3TZVJT2JLRAEFLJA5CNFSM4KISZM2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKF6VSQ#issuecomment-579594954>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABU2FGBBFDDFGIEAHU5GRU3RAEFLJANCNFSM4KISZM2A> .

[msqar]

@shamilovtim i know, that's why my changes are in my own project, I got all the files from gifted-chat and made my own version. I should make these changes in this official repo. I will whenever I have some time.

About the SafeAreaView, i don't like having a SafeAreaView, it creates that gap automatically in iPhoneX phones... that's why i had to do my own changes because i want it this way, and some people might not like it.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.